ASP.NET MVC model validation always fails

Question

I have the below action method in my controller. But seems like Model.IsValid() is always returning false even the validation conditions are ok and not showing the success message. Any help would be appreciated.

    [ActionName("CreateNewEmployeeForm")]
    [HttpPost]
    public ActionResult SaveEmployee(EmployeeViewModel employee, string btnSubmit)
    {
        switch (btnSubmit)
        {
            case "Save Employee":
                if (ModelState.IsValid)
                {
                    ViewBag.Message = "Thanks! We got your information.";
                    return View();
                }
                else
                {
                    return View();
                }
                break;
            case "Cancel":
                return RedirectToAction("EmployeeForm");
        }
        return new EmptyResult();
    }

Following are the validations I have used on entity:

    [Required(ErrorMessage ="Please Enter Your Name!")]
    [MaxLength(24)]
    [MinLength(8)]
    [RegularExpression(@"^[a-zA-Z]+$", ErrorMessage = "Kindly use letters only for name")]
    public string EmployeeName { get; set; }

    public string Designation { get; set; }

    [Required]
    [MaxLength(7)]
    [MinLength(4)]
    [RegularExpression("[^0-9]*$", ErrorMessage = "Salary must be numeric")]
    public decimal Salary { get; set; }

    [Required(ErrorMessage = "Please Enter Your Date Of Birth!")]
    [DataType(DataType.DateTime)]
    public DateTime DateOfBirth { get; set; }

    [DataType(DataType.DateTime)]
    public DateTime DateCreated { get; set; }

Have you inspected your view model properties to confirm that they are indeed valid? — JB06
– JB06, Commented Nov 10, 2016 at 12:27
Just FYI, you don't need to post the form for case "Cancel", instead you should directly redirect the page to EmployeeForm using @Html.ActionLink (this will save server resources) — G J
– G J, Commented Nov 10, 2016 at 12:29
@GauravSinghJantwal not error. the program counter is never going inside the if clause, Model.IsValid() is false always — izengod
– izengod, Commented Nov 10, 2016 at 13:03

Yanga · Accepted Answer · 2016-11-10 12:50:08Z

1

You can try which validation cause the error:

foreach (ModelState state in employee.ModelState.Values.Where(x => x.Errors.Count > 0))
{

}

answered Nov 10, 2016 at 12:50

Yanga

3,0121 gold badge33 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

nocturns2 · Accepted Answer · 2016-11-10 13:16:04Z

0

Have you tried this? Since your ModelState.IsValid is only checking that they entered the right stuff, getting it out of the way, then do the switch stuff to determine what button they pushed.

[ActionName("CreateNewEmployeeForm")]
[HttpPost]
public ActionResult SaveEmployee(EmployeeViewModel employee, string btnSubmit)
{
    if (ModelState.IsValid)
    {
        switch (btnSubmit)
        {
            case "Save Employee":
                ViewBag.Message = "Thanks! We got your information.";
            ... where you want to send them after they submit their data
                break;
            case "Cancel":
            ... where you want to send them if they cancel (maybe back to the beginning)
                break;
        }
    }
    return View();
}

That way your switch logic won't get in the way. Check the employee model by putting a break on the if statement.

You can also put an if state to determine early if the btnSubmit == Cancel and redirect them away at that point without having to deal with the ModelState.IsValid or the switch.

edited Nov 10, 2016 at 13:16

answered Nov 10, 2016 at 13:10

nocturns2

66110 silver badges17 bronze badges

4 Comments

izengod Over a year ago

yes, by putting breakpoints i found the flow is never hitting the if clause, always executing the else block and coming back to the form

nocturns2 Over a year ago

Do you have a btnSubmit in your HttpGet ActionResult? How are you passing it? Usually, you httpget lets the user fill the form and submit it and the HttpPost handles the data that was submitted. If a user cancels, the form may be missing required values. Will the form process properly if you remove that btnSubmit variable?

nocturns2 Over a year ago

You can always put a hidden field in your viewmodel that you can check in the httppost to route the user if you need to.

izengod Over a year ago

I have a html form with post method and that form contains 3 buttons named as btnSubmit. Now when u click it, the value of btnSubmit is going to hit the btnSubmit parameter of SaveEmployee method which has HttpPost atrtribute. MVC model binder does that for us.

Dabbas · Accepted Answer · 2016-11-10 12:30:19Z

0

Inspect you ModelState to see what are the error messages, another thing to mention, it is not a clean way to write one action method to serve two buttons doing two different thingsm you should create two actions.

answered Nov 10, 2016 at 12:30

Dabbas

3,2588 gold badges51 silver badges78 bronze badges

Comments

Kasama Chenkhaow · Accepted Answer · 2016-11-10 15:43:48Z

0

it seems like your regex is not correct, the hat(^) should be outside of the bracket?

[RegularExpression("[^0-9]*$", ErrorMessage = "Salary must be numeric")]

Hope this help. :)

answered Nov 10, 2016 at 15:43

Kasama Chenkhaow

545 bronze badges

Collectives™ on Stack Overflow

ASP.NET MVC model validation always fails

4 Answers 4

Comments

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related