Ruby on rails - undefined method `each' for nil:NilClass

Question

Every time I submit the form I get this error: undefined method `each' for nil:NilClass. If everything is correct I can submit the form without any problems, but when there is one thing missing it gives me that error. The error sends me to this line:

views/users/new.html.haml

- @subscriptions.each do |fbs|
  = fb.radio_button :subscription_id, fbs.id, class: 'radiobtn', required: true

controllers/users_controller.rb

def new
  @user = Users::Business.new
  @subscriptions = Businesses::Subscription.all
end

def create
  @user = Users::Business.new(user_params)

  if @user.save
    sign_in(@user)
  else
    render :new
  end
end

Submitting the form will call the controller's create action, how does it look like? I suspect that you call render "new" and don't set @subscriptions. — Stefan
– Stefan, Commented Dec 15, 2016 at 11:26
did you have some deprecated warnings about TopLevel constant in rails console? if yes, try to use @subscriptions = ::Businesses::Subscription.all — Kirill Khrapkov
– Kirill Khrapkov, Commented Dec 15, 2016 at 11:27
Thank's for the edit. Like I suspected: you render the new template from within create but you don't set @subscriptions as required by the template. — Stefan
– Stefan, Commented Dec 15, 2016 at 11:40

Alex Kojin · Accepted Answer · 2016-12-15 11:29:52Z

2

Assigns subscriptions in a create action too:

before_filter :set_subscriptions, only: %w(new create) #for edit and update if needed

private
def set_subscriptions
  @subscriptions = Businesses::Subscription.all
end

Or add @subscriptions = Businesses::Subscription.all directly to create action after the saving is failed and you re-render new form.

answered Dec 15, 2016 at 11:29

Alex Kojin

5,2142 gold badges31 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mahabub Islam Prio · Accepted Answer · 2016-12-15 11:26:18Z

0

It is happening because there is no value persisted with that model . You can check the data into the rails console like ,

$rails console
> Businesses::Subscription.count

And if you see that there is no data then you can write a if ... end block to check for null value and handle it.

answered Dec 15, 2016 at 11:26

Mahabub Islam Prio

1,09511 silver badges26 bronze badges

2 Comments

Stefan Over a year ago

Businesses::Subscription.all never returns nil.

Kirill Khrapkov Over a year ago

i agree with Stefan. It returns empty relation, not nil

Collectives™ on Stack Overflow

Ruby on rails - undefined method `each' for nil:NilClass

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related