Updating old php code. Working with php < 5.4.0 but not upwards

Question

I have lots of lines this kind of code. call('someCustomFunctionName', array($paramA, &paramB, $paramC));

I have updated my server php version and it wont work anymore.

Here is SIMPLIFIED code for testing purpose. Expected output: $b is true and $c is 2

function call($function, $param_arr = array())
{   
    # Lots of code here.
    return function_exists($function) ? call_user_func_array( $function, (array) $param_arr) : '';
}

function test_a($a, $b, $c)
{
    if($a['a'] == 1)
    {
        $b = true;
        $c++;
    }
}

$a = array('a' => 1, 'b' => 2, 'c' => 3, 'd' => 4);
$b = false;
$c = 1;

call('test_a', array($a, &$b, &$c));

if($b)
{
    print '$b is true';
}
else{
    print '$b is false';
}
print '<br>';
print $c;

What error do you get in the server logs? Or are you just not getting the expected output? — aynber
– aynber, Commented Jan 9, 2017 at 17:22
It's a "pass by reference" issue: you're passing by value, but still expecting those variables to be updated as though you were passing by reference. This may help — Mark Baker
– Mark Baker, Commented Jan 9, 2017 at 17:23
"it does not work" has never helped anyone anywhere at any time to get help with code. You need to be more specific in the details: what exact behavior and error do you get? — arkascha
– arkascha, Commented Jan 9, 2017 at 17:24
before server php upgrade everything worked. No errors. Expected $b value should be true i get false. Expected $c value should be 2 i get 1 — user3524402
– user3524402, Commented Jan 9, 2017 at 17:48

Xorifelse · Accepted Answer · 2017-01-10 06:45:13Z

0

The problem is in your test_a() function you feed the array with two references $b and $c, the function however does not accept a reference value and creates a copy instead.

The solution is simple:

function test_a($a, &$b, &$c){
  if($a['a'] == 1){
    $b = true;
    $c++;
  }
}

edited Jan 10, 2017 at 6:45

answered Jan 10, 2017 at 5:40

Xorifelse

7,9411 gold badge29 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Updating old php code. Working with php < 5.4.0 but not upwards

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related