Turn if/else statement into switch statement

Question

I have found an example on http://www.w3schools.com/ of how to create a responsive navigation bar

The example has a little bit of JavaScript in the form of a if/else statement. I would prefer to use a switch statement.

However, my switch statement does not work when i click the icon and does not provide any errors.

Example's JS code:

    var x = document.getElementById("myTopnav");
    if (x.className === "topnav") {
        x.className += " responsive";
    } else {
        x.className = "topnav";
    }

My Switch statement:

var x = document.getElementById("myTopnav");
switch (x) {
    case "topnav":
        x.className += " responsive";
        break;

    default:
        x.className = "topnav";
}

make it switch (x.classname) rather than switch (x) --- and I was a day late and a dollar short. lol — Snowmonkey
– Snowmonkey, Commented Jan 24, 2017 at 19:48

David · Accepted Answer · 2017-01-24 19:48:12Z

3

You're comparing x:

switch (x)

But the original code is comparing x.className:

if (x.className === "topnav")

Switch on x.clasName instead:

switch (x.className)

answered Jan 24, 2017 at 19:48

David

221k42 gold badges245 silver badges337 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

random_user_name · Accepted Answer · 2017-01-24 19:49:09Z

2

You are very close!

Just swap in x.className in your switch(x) statement, and you're good to go:

var x = document.getElementById("myTopnav");
// use x.className below...
switch (x.className) {
    case "topnav":
        x.className += " responsive";
        break;

    default:
        x.className = "topnav";
}

answered Jan 24, 2017 at 19:49

random_user_name

26.3k7 gold badges81 silver badges119 bronze badges

Collectives™ on Stack Overflow

Turn if/else statement into switch statement

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related