How to use Simple Injector in an Asp.Net MVC helper method

Question

I have a simple Asp.net MVC helper method in App_Code.

@helper ApprovedStatus(TimeWorkedEntry entry)
{
   if (!entry.Authorised)
   {
    var approvers =   <<get list of approvers from service here >>

    <a tabindex="0"
       role="button"
       class="exclamation"
       data-html="true"
       data-toggle="popover"
       data-trigger="focus"
       title="<b>Not yet approved</b>"
       data-content="@approvers">
        !
    </a>
}
}

My services are normally injected into the controllers within my application by Simple Injector.

What i cannot workout is how to get an instance of my services injected into a helper method. What is it I am missing?

You shouldn't. You should be passing the values to your view by adding the values to your view model within your controller. — Luke
– Luke, Commented Feb 3, 2017 at 14:43

Steven · Accepted Answer · 2017-02-03 14:25:49Z

1

You're missing nothing. Views should be dumb and should especially not have any logic or call any services. That's something that should be in the controller.

So in your case, the controller should pass the list of approvers on to the view through the view model. The view can pass this information on to the helper method.

This keeps the code clean, simple and testable.

answered Feb 3, 2017 at 14:25

Steven

174k26 gold badges355 silver badges453 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Lobsterpants Over a year ago

Doh! of course, not sure why I thought I needed to inject it there, think I forgot it wa sreally just a bit of the view! thanks

Luke Over a year ago

ASP.NET Core has an @inject directive but that's just down right dirty!!! (Except for view localization)

Steven Over a year ago

@Luke: I would even go as far as saying that the inject directive is even dirty when doing view localization.

Luke Over a year ago

I'd tend to agree with you there @Steven

Collectives™ on Stack Overflow

How to use Simple Injector in an Asp.Net MVC helper method

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related