Reflection in generic java class

Question

I have followings classes (it's just a simplified example):

public abstract class Material {
    public abstract String name();
    /* ... */
}

public class Wood extends Material {
    @Override
    public String name() {
        return "<WOOD>";
    }
    /* ... */
}

public class Metal extends Material {
    @Override
    public String name() {
        return "{Metal}";
    }
    /* ... */
}

public class Car<T extends Material> {
    public void printName() {
        System.out.println(T.name()); // Here is the problem!
    }
    /* ... */
}

public class Main {
    public static void main(String[] args) {
        Car<Wood> myCar1 = new Car<Wood>();
        Car<Metal> myCar2 = new Car<Metal>();
        myCar1.printName();
        myCar1.printName();
    }
}

The problem is indicated in the code.

I don't think the question has anything to do with reflection.Please change the title name and tag. — Emil
– Emil, Commented Nov 18, 2010 at 12:07

aioobe · Accepted Answer · 2010-11-18 12:10:39Z

3

This is probably how I would have implemented it. If it satisfactory or not for your situation, I can't tell.

enum Material {

    WOOD("<WOOD>"),
    METAL("{Metal}");

    String name;
    private Material(String name) {
        this.name = name;
    }
    public String toString() {
        return name;
    }
}

class Car {
    Material material;
    public Car(Material material) {
        this.material = material;
    }
    public void printName() {
        System.out.println(material);
    }
}

public class Main {
    public static void main(String[] args) {
        Car myCar1 = new Car(Material.WOOD);
        Car myCar2 = new Car(Material.METAL);
        myCar1.printName();
        myCar2.printName();
    }
}

answered Nov 18, 2010 at 12:10

aioobe

423k115 gold badges831 silver badges844 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alexander Pogrebnyak · Accepted Answer · 2010-11-18 12:04:39Z

2

Here is one problem:

name is instance method ( not static ), but you are trying to call it as static.

This should fix it

public class Car<T extends Material> {
    public void printName( T material ) {
        System.out.println( material.name()); 
    }
    /* ... */
}

answered Nov 18, 2010 at 12:04

Alexander Pogrebnyak

45.8k10 gold badges111 silver badges123 bronze badges

3 Comments

aioobe Over a year ago

No that won't work... First of all you can't override static methods, so this doesn't make sense.

barroco Over a year ago

I really want the 'name' method was static. But if it can't then I have to remodel my design. Thanks so much.

aioobe Over a year ago

But this won't work. static methods aren't virtual, so you'll always end up with Material.name() in this case.

Armand · Accepted Answer · 2010-11-18 12:05:01Z

1

The problem is that you're trying to call an instance method without having an instance of the object on which to call it.

answered Nov 18, 2010 at 12:05

Armand

24.5k21 gold badges93 silver badges122 bronze badges

Comments

Nicolas · Accepted Answer · 2010-11-18 12:11:43Z

1

There are a lot of misunderstanding in your question:

name() is not a static function, therfore you need an instance of a material object to call it.
even if name() were static, you cannot call a static method from a generic name.

A solution? Create a enumeration of material:

public enum Material {
    WOOD("wood"), 
    METAL("metal");

    private final String name;

    Material(String name) {
        this.name = name;
    }
}

And in the car class became:

public class Car {
    private final Material m;

    public Car(Material m) {
        this.m = m
    }

    public void printName() {
        System.out.println(m.name);
    }
    /* ... */
}

edited Nov 18, 2010 at 12:11

answered Nov 18, 2010 at 12:05

Nicolas

24.8k5 gold badges62 silver badges67 bronze badges

Comments

khachik · Accepted Answer · 2010-11-18 12:07:52Z

0

T defines the type, and the name() should be static to be called in that context. Also, consider:

public class Car<T extends Material> {
    protected T material;
    // initialize material in constructor or wherever you want.
    ....
    public void printName() {
        System.out.println(material.name()); // there is no problem
    }
    /* ... */
}

answered Nov 18, 2010 at 12:07

khachik

28.8k10 gold badges63 silver badges98 bronze badges

Comments

G B · Accepted Answer · 2010-11-18 12:20:17Z

0

This will never work, since your 'T' is only a "compiler hint", and you can't access the class defined by T at runtime, unless you refer to it explicitly in your functions.

That's not how java generics work: when you compile your code, any reference to Wood and Metal is lost, and your 2 "Car" objects are identical.

Try this:

myCar1 = new Car<Wood>();
System.out.println(myCar1 instanceof Car<Metal>);

answered Nov 18, 2010 at 12:20

G B

3,0343 gold badges31 silver badges54 bronze badges

Collectives™ on Stack Overflow

Reflection in generic java class

6 Answers 6

Comments

3 Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

3 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related