Doc with ObjectId Array - push value if exists, remove otherwise

Question

I'm new to MongoDB and mongoose.

So my model holds many fields, amongst them is an Array of ObjectIDs

var modelSchema = new Schema({
    //...
    inner_array: [Schema.Types.ObjectId],
    //...
});

What I'm trying to achieve with my query is:

Find a model by it's Id,

If the inner array contains a specific value remove it from the array.

If the value is not within the inner_array, push it

var target_id = // document id
var inner_object_id = // value to push

models.MyModel.findOne(
    {_id: target_id},
    function (err, model) {
    // IN THIS SCOPE 'INNER_OBJECT_ID' IS UNDEFINED

    // if model.inner_array contains 'inner_object_id', remove it
    // otherwise, push 'inner_object_id' into model.inner_array

    model.save();
    res.json(model); // return modified document to client
    }
);

I believe this can be written in a single findOneAndUpdate, but I can't figure out the syntax..

Thanks alot!

Abdud Dayan Adeeb · Accepted Answer · 2017-02-11 15:57:57Z

1

I believe you can achieve that using MongooseArray.pull and MongooseArray.addToSet

var target_id = // document id
var inner_object_id = // value to push

models.MyModel.findOne({
  _id: target_id
}, function (err, model) {
  if (model.inner_array.indexOf(inner_object_id) !== -1) {
    model.inner_array.pull(inner_object_id);
  } else {
    model.inner_array.addToSet(inner_object_id);
  }
  model.save();
  res.json(model); // return modified document to client
}

answered Feb 11, 2017 at 15:57

Abdud Dayan Adeeb

6191 gold badge5 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Moka Over a year ago

There was a problem with doing it this way, in the callback function - the 'inner_object_id' variable is undefined. It was defined before

Moka Over a year ago

Okay I seem to have passed the variable using .bind()

Abdud Dayan Adeeb Over a year ago

Glad I could help.

Collectives™ on Stack Overflow

Doc with ObjectId Array - push value if exists, remove otherwise

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related