Is it correct aspnetcore way? Service & Dependency Injection

Question

so i want to create some service that accesses external API, and i want to cache common requests from the API inside of that service, it depends on 3 other services, but i want to give it its own instance of cache, MemoryDistributedCache might later be changed for something else

services.AddSingleton<ISomeApi, SomeApi>(provider => new SomeApi(
    Configuration.Get<Options>(),
    new MemoryDistributedCache(new MemoryCache(new MemoryCacheOptions())),
    provider.GetService<ILogger<SomeApi>>()
    ));

now from my Controllers i can access the api via DI, it works nicely but im not sure if its some sort of an anti-pattern or if there are better ways of doing it

i mean the real problem is separating the internal cache, requesting IDistributedMemory from one service would give me the same object as if i request it from another service, they must be separated

Why does it need to be a separate cache? Also, just a note: GetService<T>() returns null if the service is not found. So if your service really needs the logger, use GetRequiredService<T>(). — juunas
– juunas, Commented Feb 14, 2017 at 7:32
lets say one cache is backed by one Database system, second cache is backed by another — gdpm
– gdpm, Commented Feb 14, 2017 at 15:57

ssmith · Accepted Answer · 2017-02-14 18:07:18Z

1

This sounds like something you could use a proxy or decorator pattern for. The basic problem is that you have a service that does some data access, and another service responsible for caching the results of the first service. I realize you're not using a repository per se, but nonetheless the CachedRepository pattern should work for your needs. See here:

http://ardalis.com/introducing-the-cachedrepository-pattern and http://ardalis.com/building-a-cachedrepository-via-strategy-pattern

You can write your cached implementation such that it takes in the actual SomeApi type in its constructor if you don't need that part of the design to be flexible.

answered Feb 14, 2017 at 18:07

ssmith

9,0328 gold badges61 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Is it correct aspnetcore way? Service & Dependency Injection

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related