shuffle() array.. correct way to randomize array results?

Question

I am wondering if the shuffle() array function is the correct way to randomize array results.

Basically, I have some ad codes in an array, and I use this to display 1 random ad each time, but there is an ad that seems to appear much much more than anything! I mean out of 20 times it appeared about 18 times. I'd thought by randomizing the results I'd get around equal views for each ad but thats not the case.

It makes me question here. Is shuffle the correct way to do this.. or do I need something totally different?

Here is my code to grab the random ad code at a time.

if (count($eligible_ads) > 1) {
    shuffle($eligible_ads);
    echo stripslashes($eligible_ads[0]['code']);
}

Glorfindel · Accepted Answer · 2019-08-07 17:32:23Z

7

You could also simply pick a random key using array_rand, instead of shuffling the whole thing. It won't get any more random than that*. You can't say something's not random with test data based on only 20 runs. It should even out if you run it a few thousand more times.

In other words:

* As far as PRNGs go at least.

edited Aug 7, 2019 at 17:32

Glorfindel

22.8k13 gold badges97 silver badges124 bronze badges

answered Nov 19, 2010 at 5:28

deceze♦

525k89 gold badges807 silver badges954 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ahmad Fouad Over a year ago

Makes sense.. I think i should let it run for some thousand impressions first. thanks for correcting me

Alex · Accepted Answer · 2010-11-19 05:28:08Z

2

Random means Random. It wouldn't be random if it gave equal views to each ad. shuffle() randomizes the order of the elements in the array, associative or otherwise. If your goal is to give equal views to each "ad" in the array, then no, shuffle() is not what your after. You could probably write a function that uses boolean logic to give equal views though.

answered Nov 19, 2010 at 5:28

Alex

66.4k49 gold badges154 silver badges181 bronze badges

Comments

Dan Grossman · Accepted Answer · 2010-11-19 05:27:13Z

0

If you don't mind the hit of running a database query or two, throw the ads into a table, and create a column that will store how many times that ad was displayed. SELECT the row with the MIN(views) ordered by RAND() and increase the view count of the row that was selected. This will ensure every ad is viewed the same number of times, but shown in a random order.

answered Nov 19, 2010 at 5:27

Dan Grossman

52.5k10 gold badges115 silver badges101 bronze badges

1 Comment

Ahmad Fouad Over a year ago

That solution looks just great, just I didn't really want to use databases, I do not want exact equal views either..the views differentals were huge thats why I questioned if shuffle is different from array_rand for example

Collectives™ on Stack Overflow

shuffle() array.. correct way to randomize array results?

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related