Appending text in string

Question

I want to append a string at runtime but this code again add the previous word not to append new word.

Customer.java:

public String getCustomerQuestion() {
  return CustomerQuestion;
 }
public void setCustomerQuestion(String customerQuestion) {
CustomerQuestion = customerQuestion;
}
public void appendmessage(String msg){
CustomerQuestion = CustomerQuestion +" "+ msg;
}

Main.java:

Customer  _Customer =new Customer();
Request_Message Request= new Request_Message;
_Customer.setCustomerQuestion(Request.getInput());
String _string=Request.getInput();
_Customer.appendmessage(_string);
String str=__Customer.getCustomerQuestion();
System.out.println("now new Question() is"+str);

When I write ram then press enter after again when I write singh it show result: ram ram on console. I want to show display ram singh as a string. `public class Request_Message { { private String _Input;

public void setInput (String line) { _Input = line; } public String getInput() { return _Input; }`

It takes the input from a chat window.

There is no such object as __Customer? Also very strange naming scheme of instance variables. Capital letters? — Marcus Whybrow
– Marcus Whybrow, Commented Nov 19, 2010 at 8:07
Why do you use getCustomerQuestion on an object named _ITChatParticipant when you use _Customer everywhere else in your example? Is it a typo? — Erik
– Erik, Commented Nov 19, 2010 at 8:09

Jon Skeet · Accepted Answer · 2010-11-19 08:07:56Z

2

You haven't shown what Request.getInput() does. I suspect that's the problem. What happens if you run:

System.out.println(Request.getInput());
System.out.println(Request.getInput());

and enter the two different strings?

If you could post a short but complete program, we could definitely work out what's going on.

(On a side note, if you follow normal Java naming conventions it's likely to be easier for others to follow your code.)

answered Nov 19, 2010 at 8:07

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jon Skeet Over a year ago

@singh: It's hard to help, given that it's clearly a problem in Request.getInput() and you've given us no information at all about what that is.

Yuval Adam · Accepted Answer · 2010-11-19 09:30:35Z

0

Don't use string concatenation. Use a proper StringBuffer instead.

private StringBuffer customerQuestion = new StringBuffer();

public void appendmessage(String msg){
    customerQuestion.append(msg);
}

public String getCustomerQuestion() {
    return customerQuestion.toString();
}

Granted, this is probably not the cause of your specific issue (for that matter see Jon Skeet's answer), but this might be a bottleneck in the future. A StringBuffer is the proper way of having a String and concatenating text to it over time.

edited Nov 19, 2010 at 9:30

answered Nov 19, 2010 at 8:06

Yuval Adam

166k95 gold badges318 silver badges406 bronze badges

3 Comments

Jon Skeet Over a year ago

It's not at all clear whether that's appropriate, and it certainly doesn't explain the behaviour the OP is seeing.

Adeel Ansari Over a year ago

Its better to delete this post, before somebody come and suggest StringBuilder. ;)

fish Over a year ago

String concatenation being a "bottleneck" in this application is certainly going to be the least of the OPs problems

Collectives™ on Stack Overflow

Appending text in string

2 Answers 2

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related