Loop only iterating once inside function

Question

I have the following function which should return all the tournaments and corresponding rounds inside an array.

When I call the function inside the body using a print_r I get only one tournament and round returned, however there are multiple tournaments and rounds. It is like the loop exits after only one iteration

function getTournaments(){
    global $db;
        $sql = "SELECT tournament, weekNum 
                FROM schedule
                GROUP BY tournament";
        $stmnt = $db->prepare($sql);
        $stmnt->execute();
        $tournaments = $stmnt->fetchAll();

        $data = array();
        foreach($tournaments as $tournament){
                $data = array('tournament' => $tournament['tournament'], 'round' => $tournament['weekNum']);

        }//foreach
        return $data;
}//function

print_r(getTournaments());

Database dump

Here you can see the corresponding mysql statement run on the db

My output / Problem

As you can see on image below I only get one tournament and round returned when doing print_r, why am I not getting all tournaments and rounds returned inside the function array? Am I missing something here?

Instead of copying the array row by row just to rename a column, you could also use a column alias in your query SELECT tournament, weekNum as `round` and then return $stmnt->fetchAll(PDO::FETCH_ASSOC); — Paul Spiegel
– Paul Spiegel, Commented Feb 24, 2017 at 2:55
@PaulSpiegel great advise thank you will definitely start implementing mentioned suggestion, learning each day! — Tim C
– Tim C, Commented Feb 24, 2017 at 3:08

user6763587 · Accepted Answer · 2017-02-24 02:39:40Z

3

you over write $data in the loop you want to create new arrays (multidimensional):

$data[] = array('tournament' => $tournament['tournament'], 'round' => $tournament['weekNum']);

answered Feb 24, 2017 at 2:39

user6763587

Sign up to request clarification or add additional context in comments.

1 Comment

Tim C Over a year ago

So you are saying I only missed the [] on $data array...? Thank you

Mithu CN · Accepted Answer · 2017-02-24 04:03:07Z

0

You should have used $data as an array :) Use this

 $data[] = array('tournament' => $tournament['tournament'], 'round' => $tournament['weekNum']);

instead of

$data = array('tournament' => $tournament['tournament'], 'round' => $tournament['weekNum']);

answered Feb 24, 2017 at 4:03

Mithu CN

5955 silver badges11 bronze badges

Collectives™ on Stack Overflow

Loop only iterating once inside function

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related