Change textview content from an array by Button

Question

I am trying to make a small app which can give randomly added sentences for me and my friend when we hang out together. I was able to do it by use arrays and random function. The problem is the button only works at the first time I push the button, if I push it again nothing change. I am a newbie to Android and Java so I do not understand much. Here is my code:

 Random r = new Random(); //Khai báo biến random
    n = r.nextInt(14) + 0 ; //hàm tạo biến random

    //Thêm phần tử vào chuỗi
    mangtrochoi[0]=("do A");
    mangtrochoi[1]=("do B");
    mangtrochoi[2]=("do C");
    mangtrochoi[3]=("do D");
    mangtrochoi[4]=("do E");
    mangtrochoi[5]=("do F");
   /* mangtrochoi[6]=("đéo được đánh sd");
    mangtrochoi[7]=("đánh Thảo 10 cái");
    mangtrochoi[8]=("đánh Nhân 10 cái");
    mangtrochoi[9]=("đánh Nguyên 10 cái");
    mangtrochoi[11]=("đánh Bun 10 cái");
    mangtrochoi[12]=("đánh Tiến 10 cái");
    mangtrochoi[13]=("đánh Giang 10 cái");
    mangtrochoi[14]=("đéo được đánh sd");*/

    //Buoc 3: viet code
    BTNrandom.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            TVhienthi.setText(mangtrochoi[n]);
        }
    });

check the answers below...

rafsanahmad007
– rafsanahmad007

2017-03-18 09:35:01 +00:00
Commented Mar 18, 2017 at 9:35 — rafsanahmad007
– rafsanahmad007, Commented Mar 18, 2017 at 9:35

rafsanahmad007 · Accepted Answer · 2017-03-18 05:46:49Z

1

Move this code inside you Button onclickListener;

 BTNrandom.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            Random r = new Random(); //Khai báo biến random
            n = r.nextInt(14) + 0 ; //hàm tạo biến random
            TVhienthi.setText(mangtrochoi[n]);
        }
    });

So in each press you will generate a random number which will then set the text.

answered Mar 18, 2017 at 5:46

rafsanahmad007

23.9k6 gold badges51 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

bornander · Accepted Answer · 2017-03-18 05:46:28Z

0

You need to set n to a random value inside the click-handler.

BTNrandom.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            n = r.nextInt(14) + 0 ;
            TVhienthi.setText(mangtrochoi[n]);
        }
    });

answered Mar 18, 2017 at 5:46

bornander

1,2461 gold badge15 silver badges25 bronze badges

Collectives™ on Stack Overflow

Change textview content from an array by Button

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related