Alternative to using 'order' within an array

Question

I've been doing some edits to an output when working with some records and i've ran into a problem where the sorting option no longer is working.

Initially with how things were created when I would do a @record.class the output was Record::ActiveRecord_Relation < ActiveRecord::Relation

However now after making my changes the class has changed. So now when I run a @record.class the output is Array < Object.

I think this is the root reason why i've ran into this problem.

My code is

@q = @records.search(params[:q])
@records = @q.result(distinct: true).select { |k,_v| k[:disabled] }
@records = @records.order("records.updated_at desc").page(params[:page] || 1).per(params[:per] || 30)

The error I am getting is NoMethodError: undefined methodorder' for #`

Now i've tried to workout around this by

@records = @records.sort_by("records.updated_at desc")
@records = @records.paginate.page(params[:page] || 1).per(params[:per] || 30)

However the error with the first line of my solution is @records = @records.sort_by("records.updated_at desc") I'm not able to get past that line in case there is an error with my paginate solution.

If anyone could take a look, I would really appreciate it!

It would be useful if you shared where the search method is coming from (and if you wrote it, the code). — coreyward
– coreyward, Commented Mar 21, 2017 at 16:41
What is the reason that you use select to select certain records (which loads all record from the database) instead of using where and make only load matching records from the database? That would be much faster. — spickermann
– spickermann, Commented Mar 21, 2017 at 16:41

Luiz E. · Accepted Answer · 2017-03-21 16:37:55Z

1

your @records is a Ruby array, not an ActiveRecord "array"
You can try @records.sort_by(&:updated_at) to sort your array

answered Mar 21, 2017 at 16:37

Luiz E.

7,34912 gold badges64 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

coreyward · Accepted Answer · 2017-03-21 16:45:56Z

1

The issue is that you are calling result, which is causing the SQL query to be executed and data returned from the database. You don't want to do that if you want to continue forming your query using the Arel AST that ActiveRecord uses. You want something closer to this (you'll likely need to adapt):

r = records.where(some_param: some_value, disabled: true) \
           .order(updated_at: :desc) \
           .page(params[:page] || 1).per(params[:per] || 30)

answered Mar 21, 2017 at 16:45

coreyward

80.5k21 gold badges148 silver badges176 bronze badges

Comments

spickermann · Accepted Answer · 2017-03-21 19:00:07Z

1

The signature you the methods you use look like you are using ransack.

Instead of loading all records into memory and selecting matching records in Ruby it might be much faster to only load matching records from database in the first place.

Assuming that disabled is a boolean column in your database, I would advise to change

@q = @records.search(params[:q])
@records = @q.result(distinct: true).select { |k,_v| k[:disabled] }
@records = @records.order("records.updated_at desc").page(params[:page] || 1).per(params[:per] || 30)

to

@q = @records.where(disabled: true).search(params[:q])
@records = @q.result(distinct: true)
@records = @records.order("records.updated_at desc").page(params[:page] || 1).per(params[:per] || 30)

edited Mar 21, 2017 at 19:00

answered Mar 21, 2017 at 16:46

spickermann

108k9 gold badges115 silver badges147 bronze badges

2 Comments

kdweber89 Over a year ago

I really love your concerns with this one, as i have around 9,000 records to work with all together, and it does take a little time to load sometimes disabled is a boolean, however when I looked into your approach, I wind up with undefined method 'where' for #<Ransack::Search:0x007ff9e671fd58> Is there a way around this?

spickermann Over a year ago

I updated my answer. There where needs to be before all ransack methods in the chain.

Collectives™ on Stack Overflow

Alternative to using 'order' within an array

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related