Update SQL query is not working in Java Swing

Question

Here i made table called sub_master with column sub_id and name, insertion and deletion working perfectly fine with this, so put those functions here as well to get reference for update function and i'm using PostgreSQL for this. In command line UPDATE query is working fine and query as: UPDATE school_submaster SET name ='' WHERE sub_id = ;

private void InsertRowActionPerformed(java.awt.event.ActionEvent evt) 
{                                          
  String query = "INSERT INTO school_submaster (sub_id, \"name\") VALUES ("+SidInput.getText()+",'"+SnameInput.getText()+"')";
  executeSQlQuery(query, "Inserted");
}                                         

private void UpdateRowActionPerformed(java.awt.event.ActionEvent evt)    
{                                          
  String query = "UPDATE school_submaster SET 'name' ='"+SnameInput.getText()+"'+WHERE sub_id = "+SidInput.getText();
  executeSQlQuery(query, "Updated");
}                                         

private void DeleteRowActionPerformed(java.awt.event.ActionEvent evt) 
{                                          
    String query = "DELETE FROM school_submaster WHERE sub_id = "+SidInput.getText();
    executeSQlQuery(query, "Deleted");
}

1) "Update SQL query is not working in Java Swing" Does it work in the command line? If not, it's a pretty good indication that Swing has nothing to do with the problem, and should not be mentioned. Same goes for your IDE mentioned in the tags. 2) Use a PreparedStatement rather than raw strings when accessing a DB. 3) Please learn common Java nomenclature (naming conventions - e.g. EachWordUpperCaseClass, firstWordLowerCaseMethod(), firstWordLowerCaseAttribute unless it is an UPPER_CASE_CONSTANT) and use it consistently. — Andrew Thompson
– Andrew Thompson, Commented Apr 2, 2017 at 12:44
For better help sooner, post a minimal reproducible example or Short, Self Contained, Correct Example. — Andrew Thompson
– Andrew Thompson, Commented Apr 2, 2017 at 13:20
What is the error you get? "Not working" is not a proper error description. Also, but: please learn how to properly use a PreparedStatement (maybe that even fixes your problem) — user330315
– user330315, Commented Apr 2, 2017 at 16:34

Gordon Linoff · Accepted Answer · 2017-04-02 12:40:34Z

2

Only use single quotes for string and date constants. Never use single quotes around column names or table names.

Your update is:

UPDATE school_submaster
    SET 'name' ='<something>'+WHERE sub_id = "+SidInput.getText();

This has the additional issue of a + in the query string. It should look ore like:

UPDATE school_submaster
    SET name = '<something>'
    WHERE sub_id = "+SidInput.getText();

But even that is not true. You need to learn to use parameters to pass parameters into queries. The query should be some variant of:

UPDATE school_submaster
    SET name = ?
    WHERE sub_id = ?

Where the ? is a placeholder for a parameter (it might also be @name or something else).

answered Apr 2, 2017 at 12:40

Gordon Linoff

1.3m62 gold badges706 silver badges857 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Vasu · Accepted Answer · 2017-04-02 12:36:55Z

0

You are missing a space in the sql WHERE clause, so add it as shown below:

String query = "UPDATE school_submaster SET 'name' ='"+
                 SnameInput.getText()+"'  WHERE sub_id = "+SidInput.getText();

answered Apr 2, 2017 at 12:36

Vasu

22.6k11 gold badges54 silver badges71 bronze badges

Collectives™ on Stack Overflow

Update SQL query is not working in Java Swing

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related