Jquery scope question

Question

My first foray into writing jQuery functions.

I have this function, but I'm not sure why the overlay var has to be outside the scope of the click function. I tried it within but it doesn't work right. Can I refactor this to make it better?

(function($) {
  $.fn.popOver = function() {

    // Variable for overlay
    var overlay = $("<div id='overlay'></div>");

    // Listen for clicks
    return this.click(function(e) {

      // Prevent the anchor link from loading
      e.preventDefault();

      // Variable for popover
      var popover = $(this).next();

      // Append the overlay to the document body
      $('body').append(overlay.click(function() {
        overlayHide();
      }))

      //Set the css and fade in our overlay
      overlay.show();
      popover.fadeIn(150);

      // Listen for clicks on elements
      popover.find('a').click(function() {
        overlayHide();
      })

      // Hide Overlay function
      function overlayHide() {
        overlay.remove();
        popover.fadeOut(150);
      }

    })
  }
}) (jQuery);

Better means shorter? Do yo have any problems with this code? — Felix Kling
– Felix Kling, Commented Dec 19, 2010 at 0:15
It'd be nice if you could indent your inner functions for better readability. — deceze
– deceze ♦, Commented Dec 19, 2010 at 0:16
@deceze Right, the lack of indentation just made me miss the main click() handler :( — alex
– alex, Commented Dec 19, 2010 at 0:18

alex · Accepted Answer · 2010-12-19 00:22:57Z

1

Because you are not doing anything more specific than simply calling that other function, you can change lines like this...

popover.find('a').click(overlayHide);

edited Dec 19, 2010 at 0:22

answered Dec 19, 2010 at 0:16

alex

492k205 gold badges891 silver badges992 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Jquery scope question

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related