How do I compare the value of string array? [duplicate]

Question

I have declared a string array and I want to compare with name given by user,

string[] MasterList = new string[] {
  "Askay", "Puram", "Raman", "Srinivasa",
  "Gopal", "Rajesh", "Anju", "Nagara",
};

string YourName;
Console.WriteLine("Enter your name: ");
YourName = Console.ReadLine();

for(i=0; i<5; i++)
{
    a = String.Compare(MasterList[i], YourName);
    Console.WriteLine("Your name is not among the list")
}

The resulting output is not what I am expecting, any ideas how I can go about it?

Why use i<5 when you have more than 5 indices in your array? Why not MasterList.Length? — Drew Kennedy
– Drew Kennedy, Commented Jul 6, 2017 at 14:24
Your code doesn't compile and you havent told what you expect. But simple: if(!MasterList.Contains(YourName)){...} instead of the for-loop. — Tim Schmelter
– Tim Schmelter, Commented Jul 6, 2017 at 14:25

Dmitrii Bychenko · Accepted Answer · 2017-07-06 14:26:03Z

2

Why not Contains?

  string[] MasterList = new string[] {
    "Askay", "Puram", "Raman", "Srinivasa",
    "Gopal", "Rajesh", "Anju", "Nagara",
  };

  Console.WriteLine("Enter your name: ");
  string YourName = Console.ReadLine();

  // StringComparer.OrdinalIgnoreCase if you want to ignore case
  // MasterList.Contains(YourName) if you want case sensitive 
  if (!MasterList.Contains(YourName, StringComparer.OrdinalIgnoreCase))
    Console.WriteLine("Your name is not among the list")

answered Jul 6, 2017 at 14:26

Dmitrii Bychenko

188k20 gold badges178 silver badges231 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Salah Akbari · Accepted Answer · 2017-07-06 14:37:45Z

2

Why not use the Contains method?

Add the following line to your using directives first:

using System.Linq;

And then, remove the for loop and use the following line instead:

if (!MasterList.Contains(YourName, StringComparer.OrdinalIgnoreCase))
{
    Console.WriteLine("Your name is not among the list")
}

edited Jul 6, 2017 at 14:37

answered Jul 6, 2017 at 14:25

Salah Akbari

40k10 gold badges85 silver badges115 bronze badges

1 Comment

LONG Over a year ago

I think using Contains here is not safe, even it Contains, still may not be the name, should be fully matched

Peter Meadley · Accepted Answer · 2017-07-06 14:30:33Z

-1

bool found = false;
foreach (string s in MasterList)
{
    if(s == YourName)
    found = true;
}
if(found)
    Console.WriteLine("Your name is among the list");
else
    Console.WriteLine("Your name is not among the list");

edited Jul 6, 2017 at 14:30

answered Jul 6, 2017 at 14:27

Peter Meadley

5192 silver badges16 bronze badges

8 Comments

garfbradaz Over a year ago

Can people who are downvoting please give some comments to @Peter who is a relatively new user :)

Jamiec Over a year ago

@garfbradaz if Peter cannot work out what is wrong with his answer there is always How to write a good answer

gravity Over a year ago

Comparing strings with == operators can yield unpredictable results (I did not downvote). You're referencing to see if it's the exact same object (which strings often are not, regardless of contents).

Peter Meadley Over a year ago

@gravity see stackoverflow.com/questions/1659097/…

Frederick Ottache Over a year ago

Thanks man...it worked just as i wanted it! thanks @Peter Meadley

|

Collectives™ on Stack Overflow

How do I compare the value of string array? [duplicate]

3 Answers 3

Comments

1 Comment

8 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

8 Comments

Linked

Related