Why if statement is not working in Java/Android?

Question

I am creating an Android program and when a button is clicked, it checks if the 2 images are the same (ImageView and EmojiconTextView). EmojiconTextView is from a library that I am using in my app.

public void clickedCheck(View view) {

    String input = emojiconTextView.getTag().toString();
    String input2 = myRandomImage.getTag().toString();

    if (input.equals(input2)) {
        checkingText.setText("Well Done!");
    } else {
            checkingText.setText("Unlucky!");
    }
}

However, when I click the button, the program displays "Unlucky" even if the images are equal. So it totally disregards my 'if-statement'.

This is my ImageView attribute:

<ImageView
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:id="@+id/myRandomImage"
        android:tag="myTag2"
        android:layout_above="@+id/emojicon_text_view"
        android:layout_centerHorizontal="true"/>

And this is is from my EmojiconTextView:

<hani.momanii.supernova_emoji_library.Helper.EmojiconTextView
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:id="@+id/emojicon_text_view"
        android:textColor="@android:color/black"
             android:textAppearance="@style/TextAppearance.AppCompat.Large"
        android:text="Emojicon Text View"
        android:layout_centerVertical="true"
        android:layout_centerHorizontal="true"
        android:tag="myTag"
        android:layout_marginTop="26dp"/>

If you need further help with understanding the question, please let me know.

You compare tags and you use different tags in xml

DeKaNszn
– DeKaNszn

2017-07-13 12:55:37 +00:00
Commented Jul 13, 2017 at 12:55 — DeKaNszn
– DeKaNszn, Commented Jul 13, 2017 at 12:55
So must the tags be the same?

MSP
– MSP

2017-07-13 12:59:34 +00:00
Commented Jul 13, 2017 at 12:59 — MSP
– MSP, Commented Jul 13, 2017 at 12:59
ur clearly comparing two strings therfore they must be same

Avinash Roy
– Avinash Roy

2017-07-13 13:00:26 +00:00
Commented Jul 13, 2017 at 13:00 — Avinash Roy
– Avinash Roy, Commented Jul 13, 2017 at 13:00

Abdul Waheed · Accepted Answer · 2017-07-28 07:01:28Z

3

Because you are using different tag in your xml code. See below

you are setting tag EmojiiconTextView as

android:tag="myTag"

on the other hand you are setting tag on ImageView as

android:tag="myTag2"

And you are comparing tags using equal method as

 if (input.equals(input2)) {
    checkingText.setText("Well Done!");
}

How could they be equal? :)

Hope that makes sense.

edited Jul 28, 2017 at 7:01

user8023414

answered Jul 13, 2017 at 12:56

Abdul Waheed

4,7186 gold badges38 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

MSP Over a year ago

So are you saying that my tags must be the same?

Abdul Waheed Over a year ago

I am not saying they must be equal. I am pointing the wrong thing you are doing. Your testing conditional statements suggests they both must be same to pass equal test.

MSP Over a year ago

Ohh, I see. So is there a correct way to do this and get them to compare? :)

MSP Over a year ago

However, my code is still not working the way I want it too :)

MSP Over a year ago

I would like to compare the ImageView and the EmojiconTextView. I want my program to see whether they're the same images, or different images. See the ImageView displays a random image and then a user selects another image. And if the user selected the correct image (the images are equal in the ImageView and EmojiconTextView then it must say "Well Done", otherwise if the user is wrong, then it must display "Unlucky" :)

Rafa · Accepted Answer · 2017-07-13 16:48:55Z

1

Like @AbulWaheed said, since you are setting your tag inside of your xml resource file, every time you do

 if (input.equals(input2)) {
    checkingText.setText("Well Done!");
} else {
        checkingText.setText("Unlucky!");
}

you will always compare the tag that set inside of your xml file. To get around this are you setting the drawable that will show up for the ImageView in the Java code?

If you are, you can also set the tag with imageview.setTag("tagName") for I'm assuming both the emojiView and the imageView.

That way, you can have some sort of map HashMap<Drawable, String> map and when you choose what Drawable you are going to use in your imageview, you automatically set the tag.

String tag = map.get(Drawable)
imageview.setTag(tag)

edited Jul 13, 2017 at 16:48

answered Jul 13, 2017 at 16:31

Rafa

3,3695 gold badges42 silver badges76 bronze badges

Comments

cabo · Accepted Answer · 2017-07-13 13:00:04Z

0

May it be that new String("myTag").equals("myTag2") gives false? Try to print input1 and input2 to corroborate.

answered Jul 13, 2017 at 13:00

cabo

1371 silver badge10 bronze badges

Comments

Mohammad nabil · Accepted Answer · 2017-07-13 13:06:41Z

0

public void clickedCheck(View view) {

    int input = Integer.parseInt(emojiconTextView.getTag());
    int input2 = Integer.parseInt(myRandomImage.getTag());

    if (input == input2) {
        checkingText.setText("Well Done!");
    } else {
        checkingText.setText("Unlucky!");
    }
}

edited Jul 13, 2017 at 13:06

answered Jul 13, 2017 at 13:01

Mohammad nabil

1,0202 gold badges12 silver badges23 bronze badges

2 Comments

MSP Over a year ago

It says "Incompatible Types"

MSP Over a year ago

I have tried your edited answer, and it 'parseInt (java.lang.String) in Integer cannot be applied to (java.lang.Object)

ANUJ GUPTA · Accepted Answer · 2017-07-13 13:19:05Z

0

You are comparing tags rather than comparing the images.

Check out this link about how to compare two images :- compare two images in android

answered Jul 13, 2017 at 13:19

ANUJ GUPTA

94513 silver badges22 bronze badges

1 Comment

MSP Over a year ago

Unfortunately that question says a camera image, these are not 2 camera images.

Collectives™ on Stack Overflow

Why if statement is not working in Java/Android?

5 Answers 5

5 Comments

Comments

Comments

2 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

5 Comments

Comments

Comments

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related