AngularJS Calling service from inside service - service is not defined

Question

I'm new to AngularJS ( learning from Udemy course ). I'm trying to separate functions by use ( kinda like classes in Java ), so I use more than one service. Somehow calls from controller work, but calls from another service rendering

"HelperFunctions is not defined
at Object.groceryService.getNewId (app.js:57)"

error.

The line it refers is inside the "GroceryService":

var maxID = HelperFunctions.findMaxID(groceryService.groceryItems);

while the following line works fine, as long as it's in the controller:

console.log(HelperFunctions.test);

My code for reference:

var app = angular.module('groceryListApp', ["ngRoute"]);

app.controller("GroceryListItemsController", ["$scope", "$routeParams", "$location", "GroceryService", "HelperFunctions", function($scope, $routeParams, $location, GroceryService, HelperFunctions){
    $scope.groceryItems = GroceryService.groceryItems;
    console.log(HelperFunctions.test);
    $scope.groceryItem = { id:7, completed:true, itemName: "cheese", date: new Date() };
    
    $scope.save = function(){
        GroceryService.save($scope.groceryItem);
        $location.path("/");
    }
}]);


app.service("HelperFunctions", function(){
    var findMax = {};
    findMax.test = 7;
    findMax.findMaxID = function(arrayOfGroceries){
        var max = -1;
        for(i=0;i<arrayOfGroceries.length;i++)
        {
            if(arrayOfGroceries[i]>max)
            {
                max = arrayOfGroceries[i].id;
            }
        }
        console.log("a");
        return max;
    }
    return findMax;
    });



app.service("GroceryService", function(){
    var groceryService = {};
    groceryService.groceryItems= [
        {id: 1, completed: true, itemName: 'milk', date: '2014-10-01'}, {id: 2, completed: true, itemName: 'cookies', date: '2014-10-01'},
        {id: 3, completed: true, itemName: 'ice cream', date: '2014-10-02'}, {id: 4, completed: true, itemName: 'potatoes', date: '2014-10-02'},
        {id: 5, completed: true, itemName: 'cereal', date: '2014-10-03'}, {id: 6, completed: true, itemName: 'bread', date: '2014-10-03'},
        {id: 7, completed: true, itemName: 'eggs', date: '2014-10-04'}, {id: 8, completed: true, itemName: 'tortillas', date: '2014-10-04'}     ]

    groceryService.getNewId = function(){
        if(groceryService.newId){
            groceryService.newId++;
            console.log("A" + groceryService.newId);
            return groceryService.newId;
        }
        else{
            var maxID = HelperFunctions.findMaxID(groceryService.groceryItems);
            groceryService.newId = maxID + 1;
            console.log("B" + groceryService.newId);
            return groceryService.newId;
        }
    }
    groceryService.save = function(entry){
        entry.id = groceryService.getNewId();
        groceryService.groceryItems.push(entry);
    };

    return groceryService;
});

There is also routing after this, but I figured that it's irrelevant, right?

What about passing the HelperFunctions service to the GroceryService function as a parameter — AngelSalazar
– AngelSalazar, Commented Sep 21, 2017 at 22:44
Ohh thank you. I didn't knew you had to do it. It's working now — romand
– romand, Commented Sep 21, 2017 at 22:46

bazzells · Accepted Answer · 2017-09-21 22:46:31Z

1

HelperFunctions is not defined because you haven't injected it into GroceryService.

This post should lead you in the right direction: Injecting a service into another service in angularJS.

answered Sep 21, 2017 at 22:46

bazzells

3292 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

AngularJS Calling service from inside service - service is not defined

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related