how to write test case using rspec of this method

Question

I want to write test case for below method. I'm new to unit testing. Please let me know the correct way to write test case for below method.

def create_new_user
    self.password_salt = BCrypt::Engine.generate_salt
    self.password_hash = BCrypt::Engine.hash_secret(self.password, password_salt)
    user = User.new(email: self.email, username:self.username, password_hash: password_hash, password_salt: password_salt)
    if user.valid?
      user.save ? {is_created: true, err:''} : {is_created: false, err:'Something went wrong,please try later...'}
    else
      {is_created: false, err: 'Please enter all mandetory fields..'}
    end
  end

what exactly is the problem here? You're unfamiliar with rspec syntax? Unit-testing in general? — Sergio Tulentsev
– Sergio Tulentsev, Commented Oct 6, 2017 at 12:42
@SergioTulentsev I'm new to rspec. It's being 2-3 days only with rspec. I'm looking for syntax like "expect(user).to be saved" if it's a valid user. and how to test "BCrypt::Engine.generate_salt". I mean to say how to test BCrypt should generate salt and then hash — ashish gupta
– ashish gupta, Commented Oct 6, 2017 at 12:46
Why do you think you need to test BCrypt methods? This lib is heavily tested by its developers. No need to duplicate the effort. You may check that correct methods have been called, though. expect(BCrypt::Engine).to receive(:generate_salt).and_call_original, for example. — Sergio Tulentsev
– Sergio Tulentsev, Commented Oct 6, 2017 at 12:52
@SergioTulentsev ok got it. I will not test Bcrypt but how to write test case for rest part? — ashish gupta
– ashish gupta, Commented Oct 6, 2017 at 12:56
"how to write test case for rest part" - people literally write entire books on this topic :) — Sergio Tulentsev
– Sergio Tulentsev, Commented Oct 6, 2017 at 12:57

Sergio Tulentsev · Accepted Answer · 2017-10-06 15:50:25Z

2

This may not be "an answer" per se but some comments/advice that might help point you in the right direction:

Your method looks to be returning a hash even though it's creating a new user. You should probably return the new user. If there are errors, the activerecord object will have those errors, no need to add your own errors.
Remember to test behavior. This is crucial to the change in point 1. The behavior of this method is: It returns a user record, either saved or not, that's the behavior. Test that.
You probably don't need to call user.valid?. Just call user.save
You can probably just return user.save itself, since, if it works, you'll get a user that is persisted/saved. If it doesn't you can check user.errors

edited Oct 6, 2017 at 15:50

Sergio Tulentsev

231k43 gold badges381 silver badges373 bronze badges

answered Oct 6, 2017 at 15:41

apanzerj

4973 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

apanzerj Over a year ago

@ashish gupta if this helped, can you mark this as the answer?

Collectives™ on Stack Overflow

how to write test case using rspec of this method

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related