Pygame infinite loop with keydown

Question

EDIT NO. 2

I did a second event loop within the function to check if there is a KEYUP event, and it works now. Thanks everyone who commented!

EDIT

So I've separated the display part from the moving thing and realised that it actually wasn't taking any new inputs from the keyboard, so it didn't know that pg.K_s wasn't pressed anymore, but now I don't know how to get the key_up event from within my function. Should I use event.get again?

I'm trying to make a game in Pygame where you use WASD to control the character. I wanted everything to be contained in different classes and functions, so I moved the character moving out of the main loop and into a function. Unfortunately, now whenever I press any WASD key, the sprite just goes in that direction infinitely and creates a runtime error.

def moving(self):
        counter = 0
        loop = pg.key.get_pressed()
        for i in range(0, len(loop)):
            if loop[i] == 1:
                counter += 1
            else:
                continue
        while counter == 1:
            pressed = pg.key.get_pressed()
            if pressed[pg.K_w]:
                if (self.y - 3) >= 0:
                    self.y -= 3
            elif pressed[pg.K_a]:
                if (self.x - 3) >= 0:
                    self.x -= 3
            elif pressed[pg.K_s]:
                if (self.y + 3) <= 238:
                    self.y += 3
            elif pressed[pg.K_d]:
                if (self.x + 3) <= 360:
                    self.x += 3
            self.display.fill((0, 0, 0))  
            self.display.blit(self.justin, (self.x, self.y))
            pg.display.flip()
            clock = pg.time.Clock()
            clock.tick(100)
            counter = 0
            loop = pg.key.get_pressed()
            for i in range(0, len(loop)):
                if loop[i] == 1:
                    counter += 1
                else:
                    continue

Here's the code where the moving function is called:

while True:
            for event in pg.event.get():
                if event.type == pg.QUIT:
                    pg.display.quit()
                    pg.quit()
                elif event.type == pg.KEYDOWN:
                    if (event.key == pg.K_w or event.key == pg.K_a
                        or event.key == pg.K_s or event.key == pg.K_d):
                        self.moving()

I just honestly don't know where to go from this - as soon as a button stops being pressed, counter should stay at 0, and so the while loop would close, but it just infintely sends the sprite to the edge of the screen.

Why use a counter, when you can just detect whether someone pressed a key down or lifted it? Also, if it's in a class, you shouldn't be redefining the variable clock every time, that should be part of the class. I would also separate the display logic with the movement logic, it will make things easier to read and understand. — Bradley Robinson
– Bradley Robinson, Commented Nov 2, 2017 at 15:55
Try inserting print() lines in intervals in your code to debug your code. You can see where the the game is getting caught up in some loop or an if statement that isn't working correctly. Also, take @Bradley Robinson's advice on cleaning up your code. — user8390068
– user8390068, Commented Nov 2, 2017 at 16:16

Omega0x013 · Accepted Answer · 2018-07-04 17:31:42Z

1

assuming you're trying to make the character move continuously while the mouse button is held down (if you want to make it move step by step then simply check the keys individually and add/subtract to the x & y), you would be best served abandoning the counter and instead, outside your event loop placed something like this:

keys=pg.key.get_pressed()
if keys[pg.K_w]:
    if x >= 0: x -= 3
if keys[pg.K_s]:
    if x <= 360: x += 3
if keys[pg.K_a]:
    if y >= 0: y -= 3
if keys[pg.K_d]:
    if y <= 238: y += 3

answered Jul 4, 2018 at 17:31

Omega0x013

1617 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Pygame infinite loop with keydown

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related