Selenium execute javascript only if DOM completely loaded

Question

I am trying get innerHeight, scrollHeight and scrollTop of a new page after user click the url,

driver.switch_to_window(driver.window_handles[-1]) # switch to newest window after user click some link
WebDriverWait(driver, 20).until(EC.presence_of_element_located((By.TAG_NAME, 'body')))

documentElement = driver.execute_script("return document.documentElement.scrollTop")
innerHeight = driver.execute_script("return window.innerHeight")
pageHeight = driver.execute_script("return document.body.scrollHeight")

However, These script return wrong value because it executed before the new page is completely loaded. How can I get the correct values?

You can inspect the document's ready state using JavaScript. driver.execute_script('return document.readyState') — sytech
– sytech, Commented Mar 15, 2018 at 4:24

sytech · Accepted Answer · 2018-03-15 04:35:43Z

3

You can inspect the document's ready state using JavaScript.

state = driver.execute_script('return document.readyState')
if state == 'complete':
    # the page is completely loaded

You can create your own custom expected condition that tests for this.

class document_complete(object):   
    def __call__(self, driver):
        script = 'return document.readyState'
        try:
            return driver.execute_script(script) == 'complete'
        except WebDriverException:
            return False

And use it like any other EC

WebDriverWait(driver, 20).until(document_complete())

edited Mar 15, 2018 at 4:35

answered Mar 15, 2018 at 4:27

sytech

42.7k8 gold badges77 silver badges127 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Prakash Palnati · Accepted Answer · 2018-03-15 04:22:28Z

0

As you are using driver.execute_script, you return your innerHeight, scrollHeight and scrollTop after document.onload or window.onload.

driver.execute_script(document.onload = function(){return document.documentElement.scrollTop})

window.onload is recommended.

Also you can try

driver.execute_script(window.onload=document.documentElement.scrollTop)

edited Mar 15, 2018 at 4:22

answered Mar 15, 2018 at 4:01

Prakash Palnati

3,43927 silver badges36 bronze badges

2 Comments

Ekoar Over a year ago

it return None after executed this script

Prakash Palnati Over a year ago

Ah I see it, simply please try window.onload=document.documentElement.scrollTop inside execute script

Collectives™ on Stack Overflow

Selenium execute javascript only if DOM completely loaded

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related