Trying to convert JS && operator function to C#

Question

I have JS code which I am trying to convert to C#. For some reason my C# method is returning 10 less than the return value of the JS function. I have tried changing multiple things and also checking the meaning of the && operator in JS but can't seem to figure out what I am doing wrong.

The correct return value is 97.

JavaScript Function & Usage:

function rir(t, e, c, n) {
    return t > e 
        && t <= c 
        && (t += n % (c - e)) > c 
        && (t = t - c + e),
       t
}
rir('a'.charCodeAt(0), 47, 57, 'b'.charCodeAt(0));
/* returns 97 */

C# Method & Usage:

public int Rir(int t, int e, int c, int n)
{
    if (t > e && t <= c)
        t += (n % (c - e));
    if (t > c)
        t = ((t - c) + e);
    return t;
}
Rir((int)'a', 47, 57, (int)'b');
/* returns 87 */

Those single-letter variable names and assignments in the middle of expressions definitely don't help readability. Oh dear — kingdaro
– kingdaro, Commented Apr 26, 2018 at 3:18
I don't know very much about JavaScript, this JavaScript function was pre written and also most likely was minified (guessing by the terrible naming convention). I am just trying to copy it over to C# verbatim. — Fletcher
– Fletcher, Commented Apr 26, 2018 at 3:20
@kingdaro I was thinking the same thing. Whoever wrote that needs to be punched in the face. — Darkrum
– Darkrum, Commented Apr 26, 2018 at 3:30
@Darkrum Like OP says, it's probably minified, but I still wouldn't be surprised if it were handwritten. Seen some shit, haha — kingdaro
– kingdaro, Commented Apr 26, 2018 at 3:31

qxg · Accepted Answer · 2018-04-26 03:39:49Z

2

(t = t - c + e) requires the first three condition to be true.

public int Rir(int t, int e, int c, int n)
{
    if (t > e && t <= c)
    {
        t += (n % (c - e));
        if (t > c)
            t = ((t - c) + e);
    }
    return t;
}

edited Apr 26, 2018 at 3:39

answered Apr 26, 2018 at 3:26

qxg

7,0961 gold badge31 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Trying to convert JS && operator function to C#

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related