Delete object by Id using mongoose

Question

I'm trying to create API to delete document on mongodb using mongoose.

Here's my route

router
    .route("/tasks")
    .delete('/:id', function (res, err) {
        taskSchema.findByIdAndRemove(req.params.id, (err, tasks) => {
            if (err) return res.status(500).send(err);
            const response = {
                message: "Todo successfully deleted",
                id: req.params.id
            };
            return res.status(200).send(response);
        });
    });

I get this error

Error: Route.delete() requires a callback function but got a [object String]

Luca Kiebel · Accepted Answer · 2018-06-03 22:40:59Z

2

/tasks and /tasks/:id are two different routes and you should handle them as such, if you use /tasks to display all tasks, make a route for that, and make a second route for every interaction that you already have an ID for; aka deleting, updating, and use the route without the ID for interactions you don't have an ID for, like creating tasks:

router
  .route("/tasks")
    .get(/* return all tasks */)
    .post(/* create a task */);

router
  .route("/tasks/:id")
    .delete(function (req, res) {
        taskSchema.findByIdAndRemove(req.params.id, (err, tasks) => {
            if (err) return res.status(500).send(err);
            const response = {
                message: "Todo successfully deleted",
                id: req.params.id
            };
            return res.status(200).send(response);
        });
    });

edited Jun 3, 2018 at 22:40

answered Jun 3, 2018 at 19:15

Luca Kiebel

10.1k7 gold badges34 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Harshal Yeole Over a year ago

Totally Agree!!

Hamza Haddad Over a year ago

I get the same error even after adding /:id to route

Luca Kiebel Over a year ago

@HamzaHaddad Right, now it should work, I forgot to remove the extra first argument to the .delete()

Hamza Haddad Over a year ago

I get req is not defined

Luca Kiebel Over a year ago

you should not see that error anymore, you had more problems there than I saw in the first place

Collectives™ on Stack Overflow

Delete object by Id using mongoose

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related