Incorrect syntax into IF... ELSE clause

Question

I have a really simple query like:

BEGIN TRY
BEGIN TRAN;
    DECLARE @CurrentPassword VARCHAR(255) = (SELECT TOP 1 [Password] 
                                             FROM Employee 
                                             WHERE @EmpGuid = EmpGuid)
    IF (@Password = @CurrentPassword)
        UPDATE [Employee] 
        SET [Password] = @NewPassword 
        WHERE @EmpGuid = EmpGuid

    SELECT 1;
    ELSE
        SELECT 2;

    COMMIT TRAN
END TRY
BEGIN CATCH
    ROLLBACK TRAN
END CATCH

But I really don't know why in my else clause I get

Incorrect syntax near 'ELSE'

What am I doing wrong? Regards

learn.microsoft.com/en-us/sql/t-sql/language-elements/… maybe you should read a bit more on this. "To define a statement block, use the control-of-flow keywords BEGIN and END." — Hozikimaru
– Hozikimaru, Commented Jul 25, 2018 at 18:15

marc_s · Accepted Answer · 2018-07-25 18:39:23Z

1

You you want to have more than one statement after the IF, you must use a BEGIN .... END block - like this:

BEGIN TRY
BEGIN TRAN;
    DECLARE @CurrentPassword VARCHAR(255) = (SELECT TOP 1 [Password] 
                                             FROM Employee 
                                             WHERE @EmpGuid = EmpGuid)
    IF (@Password = @CurrentPassword)
    BEGIN     --- you need a *BEGIN* here!!!
        UPDATE [Employee] 
        SET [Password] = @NewPassword 
        WHERE @EmpGuid = EmpGuid

        SELECT 1;
    END        --- and the *END* for your new *BEGIN*
    ELSE
        SELECT 2;

    COMMIT TRAN
END TRY
BEGIN CATCH
    ROLLBACK TRAN
END CATCH

edited Jul 25, 2018 at 18:39

answered Jul 25, 2018 at 18:17

marc_s

760k186 gold badges1.4k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Yogesh Sharma · Accepted Answer · 2018-07-25 18:17:23Z

0

Use explicitly begin . . end

BEGIN TRY
BEGIN TRAN
    DECLARE @CurrentPassword VARCHAR(255) = (SELECT TOP 1 [Password] 
                                             FROM Employee 
                                             WHERE @EmpGuid = EmpGuid)
    IF (@Password = @CurrentPassword)
    BEGIN

        UPDATE [Employee] 
        SET [Password] = @NewPassword 
        WHERE @EmpGuid = EmpGuid

    SELECT 1
    END

    ELSE

    BEGIN
        SELECT 2
    END

    COMMIT TRAN
END TRY
BEGIN CATCH
    ROLLBACK TRAN
END CATCH

answered Jul 25, 2018 at 18:17

Yogesh Sharma

50.2k5 gold badges31 silver badges53 bronze badges

Collectives™ on Stack Overflow

Incorrect syntax into IF... ELSE clause

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related