javascript.split not returning expected values

Question

I have a javascript value holding a string:

value = "123 / 15 - Value1"

And I'm trying to split on delimiters so that I can have each number and the string value is their own variables.

I tried this:

value = "123 / 15 - Value1"
splitVal = value.split(/[" ".,\/ -]/);
number1 = splitVal[0];
number2 = splitVal[1];
name = splitVal[2];

But when I console log number1,number2 and name I only get '123' in the console, the other 2 are blank.

What am I doing wrong here as far as splitting a string by both a hyphen and a slash, as well as spaces?

What pattern are you expecting in the string? It would be easy to hardcode a solution for this specific case, but from the context it's not clear how you're trying to parse value in a generic way. — Patrick Roberts
– Patrick Roberts, Commented Sep 14, 2018 at 14:40
@PatrickRoberts the pattern in this case should always be number / number - name with spaces between each value and delimiter but there could be cases where it could be number/number-name — Whisou138
– Whisou138, Commented Sep 14, 2018 at 14:41
[" "] I think you either want " or ` ` (space) here. This regex will match either of the two and uselessly repeats ". — VLAZ
– VLAZ, Commented Sep 14, 2018 at 14:42
Also, since you have a single character class (simplified) [ /] the sequence between the two numbers 123 / 15 matches three times, hence why you get empty results. If you put a quantifier after the square brackers ...]+ you would only get three items after splitting. — VLAZ
– VLAZ, Commented Sep 14, 2018 at 14:45

Patrick Roberts · Accepted Answer · 2018-09-14 14:44:57Z

2

You can use String.prototype.match() and a destructuring assignment with the following RegExp:

const value = '123 / 15 - Value1'
const [, number1, number2, name] = value.match(/(\d+) *\/ *(\d+) *- *(.+)/)

console.log(number1, number2, name)

answered Sep 14, 2018 at 14:44

Patrick Roberts

52.4k10 gold badges120 silver badges166 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

t.niese · Accepted Answer · 2018-09-14 15:03:38Z

2

The problem is that you split at (space) and / so 123 / 15 becomes:

[
  '123',
  // space
  '',
  // /
  '',
  // space
  '15'
]

If you know how the pattern should look like you might want to use match instead of split:

value = "123 / 15 - Value1"
matchVal = value.match(/^(\d+)\s*\/\s*(\d+)\s*-\s*(.*)$/);
console.dir(matchVal)

With match you can exactly define how the input has to be formatted and which fields of the input you want to extract.

Furthermore it allows name to be something like Value-1 with spaces if this is required, (if this is not allowed you could change the (.*) a more restrictive match):

value = "123 / 15 - Value-1 with spaces"
matchVal = value.match(/^(\d+)\s*\/\s*(\d+)\s*-\s*(.*)$/);
console.dir(matchVal)

Using regex101.com an help you to understand what earch part of the regexp does.

edited Sep 14, 2018 at 15:03

answered Sep 14, 2018 at 14:47

t.niese

41k9 gold badges78 silver badges111 bronze badges

4 Comments

Patrick Roberts Over a year ago

This should have been the accepted answer. It explains the problem and gives a tailored solution with a description of how it works (even though I posted an almost identical RegExp before this :P)

etarhan Over a year ago

@Patrick Roberts I disagree. Matching the string like so /(\d+)|(\w+)/g with a global flag seems to me a much more reusable solution.

t.niese Over a year ago

@etarhan depends on the usecase. If you want to have lazy matching then this might be true. But if you want to ensure that the input always matches a certain pattern - what you should always do to keep the code maintainable and prevent that this lazy matching is abused - then you want to test against a more restrictive pattern. That way you will find errors at an early stage. What if the input is illformed because of a bug (or on purpose) and is 10 10 / 10 Name then you might get an error (or an unwanted execution path) at an unexpected place in your code.

Patrick Roberts Over a year ago

@etarhan that kind of attitude is what introduces vulnerabilities into string sanitization libraries. Like t.niese says don't be lazy.

Emeeus · Accepted Answer · 2018-09-14 14:47:25Z

1

You could use match() instead of split():

var value = "123 / 15 - Value1"

var splitVal= value.match(/[a-z0-9]+/gi);

console.log(splitVal)

answered Sep 14, 2018 at 14:47

Emeeus

5,2922 gold badges30 silver badges42 bronze badges

1 Comment

Whisou138 Over a year ago

Yep, perfect! Thank you!

JohnPan · Accepted Answer · 2018-09-14 14:41:52Z

1

With

console.table("123 / 15 - Value1".split(/[" ".,\/ -]/))

you'll find out what really happens is that all values except for indexes 0,3,6 are empty strings

answered Sep 14, 2018 at 14:41

JohnPan

1,21013 silver badges21 bronze badges

Comments

Adam · Accepted Answer · 2018-09-14 14:45:29Z

0

You might have more luck just using a regex to pull out the values instead of trying to use delimiters.

let str = '123 / 15 - Value1';
let reg = /\w+/g;

let res;
let results = [];
while ((res = reg.exec(str)) !== null) {
    results.push(res);
}

if (results.length > 0) {
    console.log('Results = ' + results);
} else {
    console.log('No results.')
}

answered Sep 14, 2018 at 14:45

Adam

1,7541 gold badge13 silver badges16 bronze badges

Comments

ZiTAL · Accepted Answer · 2018-09-14 14:46:57Z

0

var value = "123 / 15 - Value1";
var r = value.split(/\s?[\/-]\s?/);
console.log(r);
/*
[ '123', '15', 'Value1' ]
*/

answered Sep 14, 2018 at 14:46

ZiTAL

3,6019 gold badges38 silver badges52 bronze badges

Comments

brk · Accepted Answer · 2018-09-14 14:55:34Z

0

The regex in your code is resulting in ["123", "", "", "15", "", "", "Value1"] .You can see in 1 & 2 index they are empty space. You can slightly modify the regex

var value = "123 / 15 - Value1";

var splitVal = value.split(/[\/-]/),
  number1 = splitVal[0].trim(),
  number2 = splitVal[1],
  name = splitVal[2];

console.log(number1, number2, name)

answered Sep 14, 2018 at 14:55

brk

50.3k10 gold badges59 silver badges85 bronze badges

Comments

patrick.1729 · Accepted Answer · 2018-09-14 16:22:58Z

0

This will work:

splitVal= value.split(/[" ".,\/ -]+/);

Add a '+' to the end of your regex. It tells the regex there must be at least one occurrence (i.e. no empty strings allowed) which is why your split is returning empty strings (as received from your regex).

edited Sep 14, 2018 at 16:22

patrick.1729

4,4222 gold badges23 silver badges32 bronze badges

answered Sep 14, 2018 at 14:45

Ilkka Peltola

896 bronze badges

Comments

Eric Nordelo Galiano · Accepted Answer · 2018-09-14 14:42:19Z

-1

You should remove white spaces before split, like this:

splitVal= value.replace(/ /g,'').split(/[" ".,\/ -]/);

answered Sep 14, 2018 at 14:42

Eric Nordelo Galiano

4554 silver badges16 bronze badges

5 Comments

t.niese Over a year ago

While this would give the correct result for the given case, you still should explain why it won't give the correct result if the spaces are not replaced.

VLAZ Over a year ago

What happens if the input is "123 // 15 - Value1"?

Patrick Roberts Over a year ago

@vlaz according to OP that's not a valid input. Parsing that string does not have to be well-defined.

VLAZ Over a year ago

@PatrickRoberts I was prodding for this answer to be re-thought and/or expanded. The issue isn't that there are spaces - it's how the regex is defined. Solving that is a much better solution. Although explanation for why this solution works is also going to be valuable.

Patrick Roberts Over a year ago

A bigger issue is that this solution would remove spaces from the name before matching it.

Collectives™ on Stack Overflow

javascript.split not returning expected values

9 Answers 9

Comments

4 Comments

1 Comment

Comments

Comments

Comments

Comments

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

9 Answers 9

Comments

4 Comments

1 Comment

Comments

Comments

Comments

Comments

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related