How to catch 500 error in Controller using Laravel

Question

I need to connect to an API so I write a function:

try {
    $res4 = $client3->post('https://api.example.co.uk/Book', [
        'headers' => [
            'Accept' => 'application/json',
            'Content-Type' => 'application/json',
            'Authorization' => 'Bearer ajhsdbjhasdbasdbasd',
        ],
        'json' => [
            'custFirstName' => $FirstName,
            'custLastName' => $Surname,
            'custPhone' => $Mobile,
            'custEmail' => $Email,
        ]
    ]);
} catch (GuzzleHttp\Exception\ClientException $e) {
    $response = $e->getResponse();
    $result = json_decode($response->getBody()->getContents());
    $item->update(['status' => 'Problems at step3']);
    Mail::raw('Problem at STEP 3', function ($message) use ($serial) {
        $message->from('[email protected]', '[email protected]');
        $message->subject('We got a problem etc.');
        $message->to('[email protected]');
    });
}

As you can see I need to make a call to API but in the case when API is down I write catch functions.

But now when API is down and API return '500 Internal Error' this function is just crashed ...

My question is why catch dont handle it?

How I can handle errors - when API is down or bad request... WHy catch{} doesn't work?

UPDATE: here is my laravel.log

[2018-10-25 14:51:04] local.ERROR: GuzzleHttp\Exception\ServerException: Server error: `POST https://api.example.co.uk/Book` resulted in a `500 Internal Server Error` response:
{"message":"An error has occured. Please contact support."}
 in /home/public_html/vendor/guzzlehttp/guzzle/src/Exception/RequestException.php:107
Stack trace:
#0 /home/public_html/vendor/guzzlehttp/guzzle/src/Middleware.php(65): GuzzleHttp\Exception\RequestException::create(Object(GuzzleHttp\Psr7\Request), Object(GuzzleHttp\Psr7\Response))
#1 /home/public_html/vendor/guzzlehttp/promises/src/Promise.php(203): GuzzleHttp\Middleware::GuzzleHttp\{closure}(Object(GuzzleHttp\Psr7\Response))

It might not be a ClientException catch the root Exception Exception instead — online Thomas
– online Thomas, Commented Oct 25, 2018 at 14:46
500 internal error is not an exception that was thrown by the way. — mighty_dev
– mighty_dev, Commented Oct 25, 2018 at 14:49
from API i got error: ServerException in RequestException.php line 107: Server error: POST https://api.exampe.co.uk/Book resulted in a 500 Internal Server Error response: {"message":"An error has occured. Please contact support."} — Aleks Per
– Aleks Per, Commented Oct 25, 2018 at 14:51

Marcin Nabiałek · Accepted Answer · 2018-10-25 15:10:24Z

6

The problem are namespaces here, instead of:

} catch (GuzzleHttp\Exception\ClientException $e) {

you should rather use:

} catch (\GuzzleHttp\Exception\ClientException $e) {

Otherwise PHP assumes that class is in current namespacase, so in fact when you used GuzzleHttp\Exception\ClientException in fact you probably used App\Http\Controllers\GuzzleHttp\Exception\ClientException and such exception obviously won't be thrown by Guzzle.

answered Oct 25, 2018 at 15:10

Marcin Nabiałek

112k43 gold badges271 silver badges300 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Aleks Per Over a year ago

no, this is not the solution, because I got the same error again. All I want is to catch error from API and update $item, also to send ALERT email to some email address

Marcin Nabiałek Over a year ago

@AleksPer Oh ok, so in error log you have GuzzleHttp\Exception\ServerException, so you can replace with this one. However because you might have different exceptions, it's better to replace with } catch (\Exception $e) { to really catch any exception that might happen here.

Aleks Per Over a year ago

catch (\Exception $e) { will catch any error on API's ? I tried and seems that works good for now

Marcin Nabiałek Over a year ago

@AleksPer Yes, it should catch any exception that appear. But if you are using PHP 7, even better is to use \Throwable just in case - see php.net/manual/en/class.throwable.php

vrerabek Over a year ago

This worked for me with 3rd party library's Exception.

mutas · Accepted Answer · 2018-10-26 11:10:01Z

2

The exception that is fired is a ServerException instance, and catch block tries to catch ClientException.

} catch (GuzzleHttp\Exception\ServerException $e) {

answered Oct 26, 2018 at 11:10

mutas

3592 silver badges9 bronze badges

Comments

Zeeshan Ahmed · Accepted Answer · 2018-10-26 11:33:11Z

1

in your app/exceptions/handler.php file, update the render method like this one.

/**
 * Render an exception into an HTTP response.
 *
 * @param  \Illuminate\Http\Request  $request
 * @param  \Exception  $exception
 * @return \Illuminate\Http\Response
 */
public function render($request, Exception $exception) {
    if ($exception instanceof \GuzzleHttp\Exception\ClientException) {
        return your_response();
    }
    return parent::render($request, $exception);
}

This approach worked for me.

answered Oct 26, 2018 at 11:33

Zeeshan Ahmed

827 bronze badges

Comments

Afonium · Accepted Answer · 2022-09-27 02:49:14Z

0

The issue is you're trying to catch an exception, when you should actually be trying to catch an error. In your catch block try using \Error instead of \GuzzleHttp\Exception\ClientException.

edited Sep 27, 2022 at 2:49

answered Aug 23, 2022 at 2:19

Afonium

11 bronze badge

Collectives™ on Stack Overflow

How to catch 500 error in Controller using Laravel

4 Answers 4

5 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

5 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related