Image upload form in PHP does nothing, no error

Question

I have the following PHP code that I am using to upload an image to MySQL. When I click submit nothing happens.

include ("connect.php");
session_start();
$login = $_SESSION['wname'];

if((@$_POST['submit'])&&(isset($_FILES["myfile"]))){
  // properties of the uploaded file
  $name = $_FILES["myfile"]["name"];
  $type = $_FILES["myfile"]["type"];
  $size = $_FILES["myfile"]["size"];
  $temp = $_FILES["myfile"]["tmp_name"];
  $error = $_FILES["myfile"]["error"];

  if($name){
    die("Error uploading file! Code $error.");
  } else {
    $place = "avatars/$name";
    move_uploaded_file($tmp_name,$place);
    $query = mysql_query("UPDATE page SET pid_image_name = '$place' WHERE wname = '$login' ");
    die("upload complete <a href='index.php'>View image</a>");
    echo "Upload complete!";
  }
} else {
  die("select a file"); 
}

Here's my form:

<form action='up.php' method='POST' enctype='multipart/form'> 
<input type='file' name='myfile'>
<p> <input type='submit' name='submit' value="upload">

What am I doing wrong?

"Nothing happens" indicates that you aren't displaying error messages or haven't even tried to debug ... get some (error)output first. — ChrisR
– ChrisR, Commented Mar 18, 2011 at 15:13
no i did that and i fix what error i had, but this time i get nada. — user621799
– user621799, Commented Mar 18, 2011 at 15:16
We are talking about logic errors, not syntax errors. No language will catch a logic error. — sethvargo
– sethvargo, Commented Mar 18, 2011 at 15:18
i check the code again and it like its not executing this part of the code if($name){ die("Error uploading file! Code $error."); } else { $place = "avatars/$name"; move_uploaded_file($tmp_name,$place); $query = mysql_query("UPDATE page SET pid_image_name = '$place' WHERE wname = '$login' "); die("upload complete <a href='index.php'>View image</a>"); echo "Upload complete!"; } } it only echo out select a file — user621799
– user621799, Commented Mar 18, 2011 at 15:28

Jonathan Makuc · Accepted Answer · 2012-03-09 16:44:25Z

3

Another important parameter to check out in php.ini is post_max_size. If you set upload_max_filesize > post_max_size the result is that no data is written to $_POST nor $_FILES for files which sizes exceed post_max_size but are below upload_max_filesize

answered Mar 9, 2012 at 16:44

Jonathan Makuc

311 bronze badge

Sign up to request clarification or add additional context in comments.

Comments

sethvargo · Accepted Answer · 2011-03-18 15:10:58Z

2

Format you're code.
Are you submitting the actual HTML form (not the PHP code) as html/multipart?? I am willing to be you're not. (enctype="multipart/form-data" needs added to your form tag!)
Learn to debug - actually put conditions elsewhere and see where your code is failing!

answered Mar 18, 2011 at 15:10

sethvargo

27k10 gold badges90 silver badges160 bronze badges

7 Comments

Chris Sobolewski Over a year ago

Agree. Let's see your HTML, I'm thinking the form is not multipart either.

user621799 Over a year ago

<html> upload file...<br> <form action='up.php' method='POST' enctype='multipart/form'> <input type='file' name='myfile'><p> <input type='submit' name='submit' value="upload"> </html>

sethvargo Over a year ago

@user621799 - FORMAT YOUR CODE!

sethvargo Over a year ago

@user621799 - That's also not Valid HTML. You never close your form and you don't even have a submit button! Post your full HTML form, FORMATTED

Michiel Pater Over a year ago

@user621799: Is this a joke? :-)

|

Silicone · Accepted Answer · 2011-03-19 14:50:57Z

1

In your HTML for have you got enctype="multipart/form-data"?
Something like this:

<form action='submit.php' method='post' enctype="multipart/form-data">

Edit 1: if you do this:

if(move_uploaded_file($tmp_name, $place)){
   echo "did move file<br />";
}else{
   echo "move failed<br />";
}

You will get move failed (Or I do with your code)

Edit 2 I found your problem:
you misspelt the temp-dir variable: you defined $temp but in the move_uploaded_file you asked for $tmp_name so here the correct code:
move_uploaded_file($temp, $place);

edited Mar 19, 2011 at 14:50

answered Mar 18, 2011 at 15:13

Silicone

6736 silver badges19 bronze badges

3 Comments

user621799 Over a year ago

here is the form, i do have that line of code already <html> upload file...<br> <form action='up.php' method='POST' enctype='multipart/form'> <input type='file' name='myfile'><p> <input type='submit' name='submit' value="upload"> </html>

user621799 Over a year ago

nada, i check the code again and it like its not executing this part of the code if($name){ die("Error uploading file! Code $error."); } else { $place = "avatars/$name"; move_uploaded_file($tmp_name,$place); $query = mysql_query("UPDATE page SET pid_image_name = '$place' WHERE wname = '$login' "); die("upload complete <a href='index.php'>View image</a>"); echo "Upload complete!"; } } it only echo out select a file

Silicone Over a year ago

Why are you checking for the $name if you are checking for an error? Shouldn't you use $error?

svanelten · Accepted Answer · 2011-03-18 15:15:45Z

-1

Just in case you can't see any errors activate error reporting by setting error_reporting(E_ALL); right after the php tag.

answered Mar 18, 2011 at 15:15

svanelten

4812 silver badges14 bronze badges

1 Comment

user621799 Over a year ago

nada, i check the code again and it like its not executing this part of the code if($name){ die("Error uploading file! Code $error."); } else { $place = "avatars/$name"; move_uploaded_file($tmp_name,$place); $query = mysql_query("UPDATE page SET pid_image_name = '$place' WHERE wname = '$login' "); die("upload complete <a href='index.php'>View image</a>"); echo "Upload complete!"; } } it only echo select a file

Collectives™ on Stack Overflow

Image upload form in PHP does nothing, no error

4 Answers 4

Comments

7 Comments

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

7 Comments

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related