problem getting my program to work

Question

I'm having a novice problem with my program here....

I want it to print a list of cities in both ascending and descending order, so far i'm only getting the descending part implemented.

#include<stdio.h>
#include<stdlib.h>
#include<string.h>
#include<ctype.h>

int main(void) {
  int i, j, ch, sort=0;
  printf("HOW WOULD YOU LIKE TO SORT?\n\nASCENDING\n\nDESCENDING\n\n");
  ch=getc(stdin);
  if(toupper(ch)=='A'&&tolower(ch)=='a') sort=1;
  if(sort==1) printf("\nSORT ASCENDING...\n");
  else printf("\nSORT DESCENDING...\n");
  printf("\nHOW MANY CITIES WOULD YOU LIKE? : - \n");
  scanf("%d",&i);
  char NAMES[i][20];
  j=0;
  while(j<i) {
    printf("ENTER NAME ");
    scanf("%s",NAMES[j]);
    j++;
  }
  char swapNAME[20];
  int r,k;
  printf("THE ORIGINAL LIST WAS :\n");
  for(r=0;r<i;r++) printf("%s\n",NAMES[r]);
  for(r=0;r<i-1;r++) {
    for(k=r+1;k<i;k++) {
      if(strcmp(NAMES[k],NAMES[r])>0) {
         strcpy(swapNAME,NAMES[r]);
         strcpy(NAMES[r],NAMES[k]);
         strcpy(NAMES[k],swapNAME);
      }
    }
  }
  printf("\n THE SORTED LIST IS NOW : \n");
  for(r=0;r<i;r++) printf("%s\n",NAMES[r]);
  getc(stdin);

  system("pause");
  return 0;
}

please any efforts made will greatly be appreciated aganin thankz

What is the exact problem? Are you getting an error? On which line of code? — Robert Harvey
– Robert Harvey, Commented Mar 27, 2011 at 14:22
An aesthetic and moot point, but do you really need to print in all caps? — PrettyPrincessKitty FS
– PrettyPrincessKitty FS, Commented Mar 27, 2011 at 14:33

Robert Harvey · Accepted Answer · 2011-03-27 14:30:44Z

2

If the descending sort is working, then all you need is an extra condition in the if statement to handle the other direction:

 for(r=0;r<i-1;r++) {
    for(k=r+1;k<i;k++) {
      if((sort==0 && strcmp(NAMES[k],NAMES[r])>0)||
         (sort==1 && strcmp(NAMES[k],NAMES[r])<0)) {
         strcpy(swapNAME,NAMES[r]);
         strcpy(NAMES[r],NAMES[k]);
         strcpy(NAMES[k],swapNAME);
      }
    }
  }

edited Mar 27, 2011 at 14:30

Robert Harvey

182k48 gold badges349 silver badges516 bronze badges

answered Mar 27, 2011 at 14:29

BMitch

271k52 gold badges555 silver badges512 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

William Pursell · Accepted Answer · 2011-03-27 15:07:50Z

0

First, your sorting is off. To fix that problem, just replace your bubble sort with a call to qsort, and that immediately leads to a good way to do your reverse sorting. In particular, try:

int
rstrcmp( const char *s1, const char *s2 )
{
    return -strcmp( s1, s2 );
}


int main( int argc, char **argv ) {
    ...
    int (*compare)(const char *s1, const char *s2 );
    /* Based on user input, set 
    compare = rstrcmp;
    -- or --
    compare = strcmp;
    */
    ...
    qsort( NAMES, i, 20, compare );
    ...

As a recommendation, do not prompt for the sort direction but let the user pass it as a flag in argv.

answered Mar 27, 2011 at 15:07

William Pursell

214k49 gold badges279 silver badges317 bronze badges

Collectives™ on Stack Overflow

problem getting my program to work

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related