Function not working on onClick event in React.js

Question

I am writing a react program where data will be fetched through an API and will be displayed in a table. There are 3 main files App.js, Table.js and Search.js and Button.js. The data is being displayed, the search is working but delete button is not working. I have written a function for delete button and I guess something is wrong in that but don't know what.

App.js

import React, { Component } from 'react';
import './App.css';
import Table from './components/Table';
import Search from './components/Search';


//API config
const DEFAULT_QUERY = 'react';
const PATH_BASE = 'https://hn.algolia.com/api/v1';
const PATH_SEARCH = '/search';
const PARAM_SEARCH = 'query=';

const url = `${PATH_BASE}${PATH_SEARCH}?${PARAM_SEARCH}${DEFAULT_QUERY}`;


class App extends Component {
  constructor(){
    super();
    //here searchText is set to DEFAULT_QUERY which will return the result for keyword "redux"
    //refer line 8 to change
    this.state={
      searchText:'',
      result:''
    }
    this.onDismiss=this.onDismiss.bind(this);
    this.onSearchChange=this.onSearchChange.bind(this);
    this.searchStories=this.searchStories.bind(this);

    //this.isSearched=this.isSearched.bind(this);
  }

  //to add a delete button
  onDismiss=(id)=>{
    //filter out item array and return results with no matched id
    const deleteList=this.state.list.filter(item=>item.objectID!==id);
    //setting state of list to lastest deleteList
    this.setState({
      result:deleteList
    })  
  }
  //to add a search bar
  onSearchChange=(e)=>{
    //set state to value in search bar
    this.setState({
      [e.target.name]:e.target.value
    })
  }

  searchStories=(result)=>{
    this.setState({
      result
    });
  }
  //after mounting will fetch the api data
  componentDidMount(){
    fetch(url)
    .then(response => response.json())
    .then(result => this.searchStories(result));
  }

  render() {
    const {result,searchText}=this.state;
    if(!result){
      return null;
    }
    return(
      <div className="page">
          <div className="interactions">

        <Search
       searchText={searchText}
       onSearchChange={this.onSearchChange}
       >
        Search
        </Search>
        </div>
       <Table
       list={result.hits}
       onDismiss={this.onDismiss}
       searchText={searchText}/>

      </div>

    )

  }
}

export default App;

Table.js

import React from 'react';
import Button from './Button';

const Table=(props)=>{
    const {list,searchText,onDismiss}=props;
    return(
        <div className="table">

       {/*Filter out item title and search title and give away results from item array */}
        {list.filter((item)=>{
          {/*The includes() method determines whether an array includes a certain value among its entries
          , returning true or false as appropriate. */}
          return item.title.toLowerCase().includes(searchText.toLowerCase());}).map((item)=>{

            return(

            <div key={item.objectID} className="table-row">
                  <span style={{ width: '40%' }}>
                        <a href={item.url}>{item.title}</a>
                        </span>
                        <span style={{ width: '30%' }}>
                        {item.author}
                        </span>
                        <span style={{ width: '10%' }}>
                        {item.num_comments} comments
                        </span>
                        <span style={{ width: '10%' }}>
                        ${item.points} points
                        </span>
                        <span style={{ width: '10%' }}>
                  <Button className="button-inline" onClick={()=>onDismiss(item.objectID)}>delete</Button>
                  </span>

            </div>

          )})}
      </div>
    )

  }


export default Table;

Button.js

import React from 'react';

const Button=(props)=>{

    const{onclick,className='',children}=props;
    return(
      <div>
          <button onClick={onclick} className={className} >{children}</button>
      </div>
    )

  }


export default Button;

try changing onDismiss={this.onDismiss} to onDismiss={() => this.onDismiss} — Sneha Bharti
– Sneha Bharti, Commented Mar 7, 2019 at 8:30

rrd · Accepted Answer · 2019-03-07 08:41:22Z

2

Your button needs to be modified slightly:

<button onClick={onClick} className={className} >{children}</button>

The handler needs to refer to the props passed in which are this.props.onClick, not this.props.onclick (which you had).

The error you are encountering can be fixed by modifying the App.js:

onDismiss = id => {
  if (id) {
    const deleteList = this.state.list.filter(item => item.objectID !== id);
    // setting state of list to lastest deleteList
    this.setState({
      result:deleteList
    }) 
  }
}

edited Mar 7, 2019 at 8:41

answered Mar 7, 2019 at 8:35

rrd

5,9873 gold badges32 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Muljayan · Accepted Answer · 2019-03-07 09:19:49Z

1

In Button component change

const{onclick,className='',children}=props;

to

const{onClick,className='',children}=props;

Also it seems that you have not set list in the state therefore when you try to access this.state.list.filter it will throw an error.

onDismiss=(id)=>{    
  const deleteList=this.state.result.hits.filter(item=>item.objectID!==id);    
  this.setState({
  result:{...this.state.result,hits:deleteList}
})

}

edited Mar 7, 2019 at 9:19

answered Mar 7, 2019 at 8:26

Muljayan

3,92611 gold badges36 silver badges58 bronze badges

5 Comments

Treycos Over a year ago

Its onClick instead of onclick, you made a typo

user11066242 Over a year ago

@Treycos that doesn't work. It makes the app crash giving an error: TypeError: Cannot read property 'filter' of undefined

Muljayan Over a year ago

@user11066242 In the code ` const deleteList=this.state.list.filter(item=>item.objectID!==id); ` of the onDismiss function you are trying to access this.state.list. Where is the list coming from ? Are you setting the list into state somewhere

user11066242 Over a year ago

@Muljayan Got it, Spot on. This was an old code and I was not updating it as per the state value. Instead I replaced it with result.hits.filter and it worked. Thank you

Muljayan Over a year ago

@user11066242 like your edit got over riden by my edit for some reason. Try to edit it again.

Collectives™ on Stack Overflow

Function not working on onClick event in React.js

2 Answers 2

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related