Variable in foreach loop does not exist outside the loop

Question

Sorry, this is pretty basic but for the life of me I have not been able to solve it:

I have this:

public static IHtmlString HrefLangLinks(this PageData currentPage)
{
    var availablePageLanguages = currentPage.ExistingLanguages.Select(culture => culture.Name).ToArray();

    foreach (string listitem in availablePageLanguages)
    {
        var Output = string.Join(",", listitem);
    } 

    // Dictionary<String, String>
    return new HtmlString(Output.ToString());
}

I would like to get the results of the foreach loop outputted in the return value. But Visual Studio informs me that "Output" (the instance in my return value) does not exist in the current context.

I thought I could solve this by adding var Output =""; outside of my foreach loop but that did not work.

Try return new HtmlString(string.Join(",", availablePageLanguages)). — Dour High Arch
– Dour High Arch, Commented Apr 7, 2019 at 19:45

Jonathan · Accepted Answer · 2019-04-07 19:54:54Z

2

Define Output before going into the foreach loop and then assign it a value:

var Output = "";

foreach (string listitem in availablePageLanguages)
{
    Output = string.Join(",", listitem);
}

Apart from that I wonder if you really need a for loop in this case as you should also be able to this at once if availablePageLanguages is an array of string (string[]):

var Output = String.Join(" ", availablePageLanguages));

edited Apr 7, 2019 at 19:54

answered Apr 7, 2019 at 19:43

Jonathan

9237 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

BrokenCode Over a year ago

Thank you for that. I was not paying attention to the "var" in my foreach loop which was creating a new instance of the variable, correct?

MichaelMilom Over a year ago

If I am not mistaken, this solution will only include the last listitem from availablePageLanguages (since Output is overwritten for each listitem). I believe that is what OP meant by "did not work). As it turns out, we both had the same idea. I think your edit is the correct solution.

Collectives™ on Stack Overflow

Variable in foreach loop does not exist outside the loop

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related