ForEach-Loop with multiple arrays

Question

I currently have 4 arrays with different names of Organizational unit from our Active Directory.

So I do a big evaluation and in order not to create a separate ForEach loop for each array (because this are like 400 lines of code) I would like to put the whole thing into a single loop.

However, I need to know when which array is run through so that I can change something for this array in certain places by IF query.

thats because not all arrays can use the code in this way and for example the searchbase for the Active Directory query must be changed for each array.

Here i created a example and described my problem in the comments. (<# #>)




$OU1="1-Users","2-Users","3-Users"
$OU2="1-Computers","2-Computers","3-Computers"
$OU3="1-ServiceAccounts","2-ServiceAccounts","3-ServiceAccounts"

foreach ($ou in $OU1 <#AND OU2,OU3#> ){

if($OU1,$OU2 <#= active#> ){

 <# if this array is active - do this code #>
 $SearchBase = "OU="+$ou+",OU=SUBOU,DC=intra,DC=lan"

}

if($OU3 <#= active#>){

 <# if this array is active - do this code #>
$SearchBase = "OU="+$ou+",DC=intra,DC=lan"

}


 <# do this code for all #>

}

I hope you understand what I mean and can help me with my problem. Thank you.

Sorry but I don't really understand what your code is trying to do or what your question is. Why are you running through AD like this? What are you trying to do? — Mark Harwood
– Mark Harwood, Commented Jun 13, 2019 at 13:23
you can iterate thru the list of lists, then thru the content of the smaller list. also, you can use a splat to add the specific values to the properties you use in a query. look into Get-Help about_Splatting for how to construct a parameter hashtable that you can add/remove/change the values as needed before you use the splat in your cmdlet call. — Lee_Dailey
– Lee_Dailey, Commented Jun 13, 2019 at 13:36

mhu · Accepted Answer · 2019-06-13 14:02:45Z

1

What Lee_Dailey means is this: First create a hashtable with the correct settings, then iterate that:

$ouList = @(
    @{ "SearchBase" = "OU=SUBOU,DC=intra,DC=lan"; "OUs" = @("1-Users","2-Users","3-Users") },
    @{ "SearchBase" = "OU=SUBOU,DC=intra,DC=lan"; "OUs" = @("1-Computers","2-Computers","3-Computers") },
    @{ "SearchBase" = "DC=intra,DC=lan";          "OUs" = @("1-ServiceAccounts","2-ServiceAccounts","3-ServiceAccounts") }
)

foreach ($item in $ouList)
{
    foreach ($ou in $item.OUs)
    {
        $searchBase = "OU=" + $ou + "," + $item.SearchBase
    }
}

answered Jun 13, 2019 at 14:02

mhu

18.1k10 gold badges67 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Michael Clemens Over a year ago

I took the other suggestion (AdminOfThings). But this also works. Thx.

mhu Over a year ago

OK, but beware that, that solution won't work when an OU name exists in both lists

AdminOfThings · Accepted Answer · 2019-06-13 13:54:30Z

0

One way to do this is to append your arrays in an expression (using +). This will effectively create a single collection that you can then use the -in operator to find a match.

$OU1="1-Users","2-Users","3-Users"
$OU2="1-Computers","2-Computers","3-Computers"
$OU3="1-ServiceAccounts","2-ServiceAccounts","3-ServiceAccounts"

foreach ($ou in $OU1+$OU2+$OU3 ){

    if( $ou -in $OU1+$OU2 ){

       <# if this array is active - do this code #>
       $SearchBase = "OU="+$ou+",OU=SUBOU,DC=intra,DC=lan"

    }

    if ($ou -in $OU3){

       <# if this array is active - do this code #>
       $SearchBase = "OU="+$ou+",DC=intra,DC=lan"

    }

    <# do this code for all #>

}

answered Jun 13, 2019 at 13:54

AdminOfThings

25.2k4 gold badges22 silver badges30 bronze badges

Collectives™ on Stack Overflow

ForEach-Loop with multiple arrays

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related