How can i get all of my users from sql datebase with using php [duplicate]

Question

In $result should be all of users from datebase, but it takes only first person and shows error.

My php code:

if ($_SERVER['REQUEST_METHOD'] == 'POST') {
    require_once 'connect.php';

    $response = mysqli_query($conn, "SELECT imie, nazwisko FROM users");

    $result = array();
    $result['osoby'] = array();

    $row = mysqli_fetch_assoc($response);

    $index['name'] = $row['imie'];
    $index['surname'] = $row['nazwisko'];

    array_push($result['osoby'], $index);
    $result['success'] = "1";

    echo json_encode($result);
}

use while loop

devpro
– devpro

2019-07-03 12:22:29 +00:00
Commented Jul 3, 2019 at 12:22 — devpro
– devpro, Commented Jul 3, 2019 at 12:22

devpro · Accepted Answer · 2019-07-03 12:34:03Z

2

Its giving you 1 record because you are only printing 1 record,

Using $row = mysqli_fetch_assoc($response); will always give you last row if you not use loop here.

You need to use while loop to get all rows like:

<?php
$i = 0;
$result = array(); // initialize 
while($row = mysqli_fetch_assoc($response)){
    $result[$i]['name'] = $row['imie'];
    $result[$i]['surname'] = $row['nazwisko'];  // store in an array
    $i++;
}
$finalResult['osoby'] = $result; // storing as you need
$finalResult['success'] = "1"; // no idea about this but adding this also
echo json_encode($finalResult); // encode with json
?>

edited Jul 3, 2019 at 12:34

answered Jul 3, 2019 at 12:29

devpro

16.1k3 gold badges29 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Vidal Over a year ago

Your code is wrong, the result[$i]['name'] is going to get rewrite always because you are not incrementing it... at the end you are going to get only 1 result....

devpro Over a year ago

@Vidal: ohh silly forgot this. thanks

Qirel · Accepted Answer · 2019-07-03 12:32:56Z

2

You can loop the result-set and append an array of your values to the $result array.

$response = mysqli_query($conn, "SELECT imie, nazwisko FROM users");

$result = ['osoby' => []];
while ($row = mysqli_fetch_assoc($response)) {
    $result['osoby'][] = ['name' => $row['imie'], 'surname' => $row['nazwisko']];
}
$result['success'] = "1";

echo json_encode($result);

If you have the mysqlnd driver installed, you can also use mysqli_result::fetch_all() method

$response = mysqli_query($conn, "SELECT imie, nazwisko FROM users");

$result = ['osoby' => mysqli_fetch_all($response, MYSQLI_ASSOC)];
$result['success'] = "1";

echo json_encode($result);

answered Jul 3, 2019 at 12:32

Qirel

26.6k7 gold badges54 silver badges71 bronze badges

3 Comments

devpro Over a year ago

$result = ['osoby' => mysqli_fetch_all($response, MYSQLI_ASSOC)]; like this approach :)

Qirel Over a year ago

Its quite neat indeed! Requires the mysqlnd driver though, but that does other cool stuff as well (like mysqli_stmt::get_result() for prepared statements).

devpro Over a year ago

yes agreed with u

Vidal · Accepted Answer · 2019-07-03 12:38:23Z

2

You have to loop the result array.

$resultJson = array();
$resultJson['osoby']=array()

$query = "SELECT imie,nazwisko  FROM users";
$result = $mysql->query( $query );
if ($result->num_rows > 0){
    while($row = $result->fetch_assoc()){
      // fetch information out of the $row..
      $resultJson['osoby'][]  = ['name' => $row['imie'], 'surname' => $row['nazwisko']];
    }

}

print json_encode($resultJson);

edited Jul 3, 2019 at 12:38

answered Jul 3, 2019 at 12:25

Vidal

2,6062 gold badges20 silver badges35 bronze badges

Collectives™ on Stack Overflow

How can i get all of my users from sql datebase with using php [duplicate]

3 Answers 3

2 Comments

3 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

3 Comments

Comments

Linked

Related