Using API Controller in Page Controller

Question

I'm starting learning asp.net core, and I have problems with understanding some basic patterns. Can I use ApiController inside PageController?

For example

//Home controller
public async Task<IActionResult> Index()
{
    var artists = await _artistController.GetAll();

    var t = artists.GetValue();

    var indexModel = new Models.Pages.IndexModel
    {
        Artists = artists.GetValue() //Extension method
    };
    return View(indexModel);
}

//ArtistRestController
[HttpGet]
public async Task<ActionResult<IEnumerable<Artist>>> GetAll()
{
    try
    {
        return Ok(await _repository.GetAll());
    }
    catch (Exception ex)
    {
        _logger.LogError(ex.Message);
        return BadRequest(ex.Message);
    }
}

It works, but is is ok by design? Maybe I should directly call _repository.GetAll() and do not use other controller?

Yes.You may inject your Repository to HomeController and use it to get the data you want. — Shyju
– Shyju, Commented Aug 19, 2019 at 18:38
Are any client side code accessing the ArtistRestController/Getall ? — the_lotus
– the_lotus, Commented Aug 19, 2019 at 18:42
if you dont want to expose the GetAll method to the outside world, you can create a private function inside the controller and remove the HttpGet attribute — Vishnu
– Vishnu, Commented Aug 19, 2019 at 18:45
Assume, that I want to have some funcionallity in Api (for example getting all artists, or posting new one) and use the same things in HomeController (have list of all artists on page, or 'Add new' button). Which approach is better - using ApiController in PageController or just inject repository and duplicate code? — JoeDoe
– JoeDoe, Commented Aug 19, 2019 at 18:49

Edward · Accepted Answer · 2019-08-20 05:25:40Z

1

First, you should avoid using one Controller in another Controller. For Controller, it is used to handle http request from client. It is unreasonable to use it as a class even through it is a class.

Second, for combining ApiController and PageController will make your application unstatable and too coupling. If you change anything later in ArtistRestController.GetAll will make HomeController broken. And, for your current code, if there are some exception in PageController, your ApiController will be down.

You should inject repository to query the data.

answered Aug 20, 2019 at 5:25

Edward

30.2k12 gold badges84 silver badges141 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Using API Controller in Page Controller

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related