Error_log: PHP Warning: A non-numeric value encountered

Question

After updating to PHP 7.3 I get the following error

PHP Warning: A non-numeric value encountered in /functions.php on line 3702

Line 3702:

$total += $rating['rating_score'];

Function code:

function airkit_get_rating( $post_id ) {

if ( is_numeric($post_id) ) {
    $rating_items = get_post_meta($post_id, 'ts_post_rating', TRUE);
    if ( isset($rating_items) && is_array($rating_items) && !empty($rating_items) ) {
        $total = '';
        foreach($rating_items as $rating) {
            $total += $rating['rating_score'];
        }
        if ( $total > 0 ) {
            $round = intval($total) / count($rating_items);
            $result = round($round, 1);

            if ( is_int($round) ) {
                if ( $round == 10 ) return $result;
                else return $result . '.0';
            } else {
                return $result;
            }
        } else {
            return;
        }
    }
} else {
    return;
}}

I have no experience in PHP. Can anyone help me to correct this error?

You're trying to add a string and a number. It will automatically convert the string to a number, but now it generates a warning. — Barmar
– Barmar, Commented Aug 30, 2019 at 22:38
Actually, this isn't a new warning, I reproduced it in PHP 5. The upgrade probably changed your default error reporting level. — Barmar
– Barmar, Commented Aug 30, 2019 at 22:39

Barmar · Accepted Answer · 2019-08-30 22:42:15Z

4

Change

$total = '';

to

$total = 0;

You're trying to add a number to a string, but the string doesn't look like a number. The empty string is converted to the number 0, so you get the correct total, but it also produces a warning.

answered Aug 30, 2019 at 22:42

Barmar

789k57 gold badges555 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

jasonwubz Over a year ago

This seems to solve the issue. But I noticed that the same error can still be triggered if $rating['rating_score'] is also a string.

Barmar Over a year ago

True, but why would that be a string?

Barmar Over a year ago

If you're trying to concatenate strings you use ., not +.

Collectives™ on Stack Overflow

Error_log: PHP Warning: A non-numeric value encountered

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related