Serializer field for integer or string

Question

I want to have serializer with field which can take integer(not floats or any other numeric type!) or string as an input.Is there any way to make it better/more pretty?

class MyField(Field):
    def to_representation(self, value):
        if isinstance(value, int):
            return value
        elif isinstance(value, str):
            return value
        else:
            raise ValidationError('Error')

    def to_internal_value(self, data):
        if isinstance(data, int):
            return data
        elif isinstance(data, str):
            return data
        else:
            raise ValidationError('Error')

class MySerializer(Serializer):
    my_field = MyField()

What if value is '1.0' (a string), do you accept it as well or not? — Arn
– Arn, Commented Nov 18, 2019 at 17:02

Arn · Accepted Answer · 2019-11-19 12:23:04Z

5

You may combine the conditions as below:

class MyField(Field):
    def to_representation(self, value):
        if isinstance(value, int):
            return value
        elif isinstance(value, str) and value.isdigit():
            return value
        raise ValidationError('Error')

    def to_internal_value(self, data):
        if isinstance(data, int):
            return data
        elif isinstance(data, str) and data.isdigit():
            return data
        raise ValidationError('Error')

class MySerializer(Serializer):
    my_field = MyField()

edited Nov 19, 2019 at 12:23

answered Nov 18, 2019 at 16:58

Arn

2,01516 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Serializer field for integer or string

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related