Filter data based on enum value

Question

I have a model that looks like this

     [Column("StatusId")]
     public FileStatus Status { get; set; }

     public int Id { get; set; }

I also have an enum that looks like this.

     public enum FileStatus
        {
            MessageInProgress,
            MessageDone,
            NoMessage
        }

I am pulling data from my repository to populate data variable below

    IEnumerable<MyFile> data = await _fileDataRepository.GetAllData(Id);

I want to filter data such that I will remove any record that has a status of MessageDone or NoMessage.

This code does not work for me.

    data.where( x => x.Status != "MessageDone" | x.Status != "NoMessage")

How do I achieve the filtering?

dont use strings. use && instead of |. don't capture as an IEnumerable as it will pull things too much. — Daniel A. White
– Daniel A. White, Commented Mar 4, 2020 at 17:19
Instead of using a string why not just use the enum itself? x.Status != FileStatus.MessageDone. Also you should have && instead of | for the comparison operator. — Jesse
– Jesse, Commented Mar 4, 2020 at 17:20
I'd add an overload GetAllData(Id, status) where status is one of FileStatus values and do the filter in the DAL. — user10216583
– user10216583, Commented Mar 4, 2020 at 18:04

itaiy · Accepted Answer · 2020-03-04 17:36:41Z

2

2 things you need to change:

FileStatus is enum and you use it as a string.
You used | which is "boolean logical or" and you should use "Conditional logical and" && (You can use & but most of the times is better to use conditional operator because of the laziness (For more details)).

You should change it to:

data.where(x => x.Status != FileStatus.MessageDone && x.Status != FileStatus.NoMessage)

Or more simple:

data.where(x => x.Status == FileStatus.MessageInProgress)

edited Mar 4, 2020 at 17:36

answered Mar 4, 2020 at 17:25

itaiy

1,3242 gold badges15 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Trevor Over a year ago

Good answer and explanation with solution; the last code snippet is best.

Baba Over a year ago

The reason why I used Or | is that I want to filter the data when the enum is MessageDone, or NoMessage. Both of this message cannot exist at the same time. It is just one at a time that can exist in the table

itaiy Over a year ago

from MSDN: The result of x | y is true if either x or y evaluates to true. As you mentioned, In your case x.Status can't be both, so one of the operands will be always true.

Baba Over a year ago

The filtering is not working. I am still getting a record back that has a status of MessageDone and it should not come back

itaiy Over a year ago

Maybe it changes after the filter? You can put a breakpoint on the setter of Status and check it.

Collectives™ on Stack Overflow

Filter data based on enum value

1 Answer 1

5 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related