How to generate a json with correct format in php?

Question

Im tryng to generate a json with data of my database, so when I receive the data all is well, the problem happens when I put the data in JSON format it looks like that is wrong:

{"comment":[{"id_comment":1,"photo":"imgU\/default.png","full_name":"MercadoPago","comment":"Primero"}]}{"comment":[{"id_comment":2,"photo":"imgU\/default.png","full_name":"MercadoPago","comment":"Segundo"}]}

So I want to generate a json that looks like:

[{"id_comment":1,"photo":"imgU\/default.png","full_name":"MercadoPago","comment":"Primero"},
{"id_comment":2,"photo":"imgU\/default.png","full_name":"MercadoPago","comment":"Segundo"}]

My code is the next:

global $id_comentador;
global $id_comentario;
global $comment;

$arregloComentarios = json_decode($row['comentarios'], true);

foreach ($arregloComentarios as $value) {

    $id_comentario = $value["id_comentario"];
    $id_comentador = $value["id"];
    $comment = $value["comment"];

    $consultarComentador = "select id,first_name,last_name,foto from users where id='$id_comentador';";

    $coo["comment"] = array();
    $arregloProyectos = traerDatos($consultarComentador);
    $num = count($arregloProyectos);

    if ($num > 0) {

        foreach ($arregloProyectos as $row2) {

            $foto = $row2["foto"];
            $foto2 = $row2["first_name"];
            $foto3 = $row2["last_name"];
            $tmp = array();
            $tmp["id_comment"] = $id_comentario;
            $tmp["photo"] = $foto;
            $tmp["full_name"] = $foto2.''.$foto3;
            $tmp["comment"] = $comment;
            global $coo;
            $coo['comments'] = array();
            array_push($coo["comments"], $tmp);

        }//Cierra foreach

        echo json_encode($coo);
    }
}

I will be grateful for your answers.

Create an array $comments outside of the top foreach and push into that one instead of $coo["comments"]. Then, do echo json_encode($comments) after the outside foreach. — CherryDT
– CherryDT, Commented Mar 8, 2020 at 0:45
@CherryDT - You should post that as an answer and include a code example. — M. Eriksson
– M. Eriksson, Commented Mar 8, 2020 at 1:14

CherryDT · Accepted Answer · 2020-03-08 01:20:47Z

1

(Copied from comment)

Create an array $comments outside of the top foreach and push into that one instead of $coo["comments"]. Then, do echo json_encode($comments) after the outside foreach.

global $id_comentador;
global $id_comentario;
global $comment;

$arregloComentarios = json_decode($row['comentarios'], true);

$comments = [];

foreach ($arregloComentarios as $value) {
    $id_comentario = $value["id_comentario"];
    $id_comentador = $value["id"];
    $comment = $value["comment"];

    $consultarComentador = "select id,first_name,last_name,foto from users where id='$id_comentador';";

    $arregloProyectos = traerDatos($consultarComentador);
    $num = count($arregloProyectos);

    if ($num > 0) {
        foreach ($arregloProyectos as $row2) {
            $foto = $row2["foto"];
            $foto2 = $row2["first_name"];
            $foto3 = $row2["last_name"];
            $tmp = array();
            $tmp["id_comment"] = $id_comentario;
            $tmp["photo"] = $foto;
            $tmp["full_name"] = $foto2.''.$foto3;
            $tmp["comment"] = $comment;

            $comments[] = $tmp;
        }//Cierra foreach
    }
}

echo json_encode($comments);

answered Mar 8, 2020 at 1:20

CherryDT

29.4k5 gold badges57 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

MARA Over a year ago

Thanks, your explanation was very helpful

Collectives™ on Stack Overflow

How to generate a json with correct format in php?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related