Couldn't insert data in MySql with PHP

Question

Here's my insert query.

$insertQuery = "INSERT INTO timeline (id_str, from_user, text, timestamp, location) VALUES ($resultsAry[$x]['id_str'], $resultsAry[$x]['from_user'], $resultsAry[$x]['text'], $datetime, $locationAry[$i]['place'])";

The values passing to the query seem correct (Checked by echo-ing all the values). But I got the following error.

Insert failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '['id_str'], Array['from_user'], Array['text'], 2011-05-23 18:58:27, Array['place' at line 1

Please help?

I think you need to quote your values.

martynthewolf
– martynthewolf

2011-05-23 11:07:13 +00:00
Commented May 23, 2011 at 11:07 — martynthewolf
– martynthewolf, Commented May 23, 2011 at 11:07

Jon Skarpeteig · Accepted Answer · 2011-05-23 11:07:37Z

2

To have PHP parse your array keys correctly you can encapsulate them with {} like this:

$insertQuery = "INSERT INTO timeline (id_str, from_user, text, timestamp, location) VALUES ({$resultsAry[$x]['id_str']}, {$resultsAry[$x]['from_user']}, {$resultsAry[$x]['text']}, $datetime, {$locationAry[$i]['place']})";

answered May 23, 2011 at 11:07

Jon Skarpeteig

4,1367 gold badges36 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Berry Langerak · Accepted Answer · 2011-05-23 11:15:27Z

2

Do yourself a favour and at the very least escape the values to secure the data. Concatenate the values into the query:

$insertQuery = "
INSERT INTO timeline (
   id_str, 
   from_user,
   text,
   timestamp, 
   location
) 
VALUES (
   '" . mysql_real_escape_string( $resultsAry[$x]['id_str'] ) . "',
   '" . mysql_real_escape_string( $resultsAry[$x]['from_user'] . "',
   '" . mysql_real_escape_string( $resultsAry[$x]['text'] . "',
   '" . mysql_real_escape_string( $dateTime ) . "',
   '" . mysql_real_escape_string( $locationAry[$i]['place']) . "'
);";

echo $insertQuery;

edited May 23, 2011 at 11:15

answered May 23, 2011 at 11:09

Berry Langerak

18.9k5 gold badges49 silver badges62 bronze badges

Comments

BlueEel · Accepted Answer · 2011-05-23 11:07:10Z

1

try this:

$insertQuery = "INSERT INTO timeline (id_str, from_user, text, timestamp, location) VALUES ('".$resultsAry[$x]['id_str']."', '".$resultsAry[$x]['from_user']."', '".$resultsAry[$x]['text']."', '".$datetime."', '".$locationAry[$i]['place']."')";

answered May 23, 2011 at 11:07

BlueEel

3594 silver badges13 bronze badges

Collectives™ on Stack Overflow

Couldn't insert data in MySql with PHP

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related