i don't know why these 2 codes have different outputs in python

Question

this is for a tic tac toe game for my project but I still don't under stand the difference between my code and my mentor's code correct code:

def player_input():
    marker = ''

    while not (marker == 'X' or marker == 'O'):
        marker = input('Player 1: Do you want to be X or O? ').upper()

    if marker == 'X':
        return ('X', 'O')
    else:
        return ('O', 'X')

my code:

def player_input():
    player1 = ""
    while player1 != "X" or player1 !="O":
        player1 = input("choose x or o : ").upper()

    if player1 == "X":
       return ("X","O")
    else:
        return ("O", "X")

Rahul Shelke · Accepted Answer · 2020-05-26 05:09:54Z

2

It's because your condition should have and and not or.

As per de morgans law:

~(p or q) => ~p and ~q

So your code should be as follows:


def player_input():
    player1 = ""
    while player1 != "X" and player1 !="O":
        player1 = input("choose x or o : ").upper()

    if player1 == "X":
       return ("X","O")
    else:
        return ("O", "X")

answered May 26, 2020 at 5:09

Rahul Shelke

2,1764 gold badges30 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

i don't know why these 2 codes have different outputs in python

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related