JavaScript: forEach function is not specifying the item to count in iteration loop

Question

I'm writing a function for a game called TwilioQuest. The function neeps to loop through each item in the freightItems array (already defined by TwilioQuest) and count each time the item 'contraband' is noticed. I created an array after the function to test the code.

The problem I'm having is that the function doesn't seem to be able to discriminate between the item 'contraband' and any other item. When the contrabandCount is returned, it displays "5" instead of the expected "2". Can anyone help me understand where I went wrong?

Here's my code:

function scan(freightItems) {
  let contrabandCount = 0;
  freightItems.forEach(function(freightItems) {
    if ('contraband') contrabandCount++;
  });
  return contrabandCount;
}

const numItems = scan(['dog', 'contraband', 'cat', 'zippers',
  'contraband'
]);
console.log('Number of "contraband": ' + numItems)

Your issue is with: if ('contraband') as you need to check if freightItem (the argument in your forEach callback) equals 'contraband' — Nick Parsons
– Nick Parsons, Commented Jun 25, 2020 at 3:02

Zartaj Majeed · Accepted Answer · 2020-06-25 03:04:13Z

3

you need to compare the freightItems value to "contraband"

freightItems.forEach(function(freightItem) {
  if(freightItem === 'contraband')
    contrabandCount++
})

answered Jun 25, 2020 at 3:04

Zartaj Majeed

5072 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Avinash Dalvi Over a year ago

same thoughts only you was quicker upvoting answer.

GattMola Over a year ago

Thank you Zartaj and aviboy! This makes a lot more sense now.

Avinash Dalvi · Accepted Answer · 2020-06-25 03:04:42Z

1

function scan(freightItems) {
  let contrabandCount = 0;
  freightItems.forEach(function(entry) {
    if (entry == 'contraband') {
      contrabandCount++;
    }
  });

  return contrabandCount;
}

const numItems = scan(['dog', 'contraband', 'cat', 'zippers',
  'contraband'
]);
console.log('Number of "contraband": ' + numItems)

answered Jun 25, 2020 at 3:04

Avinash Dalvi

9,4299 gold badges34 silver badges60 bronze badges

Comments

sonEtLumiere · Accepted Answer · 2020-06-25 03:26:45Z

0

Filter method is all you need

const numItems = ['dog', 'contraband', 'cat', 'zippers', 'contraband'];

var filtered = numItems.filter(x => x == 'contraband');
console.log('Number of "contraband": ' + filtered.length);

You can use this sintax if you want, remember compare freightItems with 'contraband'

function scan(freightItems) {
  let contrabandCount = 0;
  freightItems.forEach((freightItems) => {
    'contraband' === freightItems ? contrabandCount++ : 0;
  });
  return contrabandCount;
}

edited Jun 25, 2020 at 3:26

answered Jun 25, 2020 at 3:20

sonEtLumiere

4,6223 gold badges15 silver badges48 bronze badges

Comments

Ala Eddine Menai · Accepted Answer · 2020-06-25 03:30:29Z

0

Maybe an improved Syntax :

With forEach :

function scan(searchabelItem, freightItems, contrabandCount = 0) {
    freightItems.forEach((value) => value === searchabelItem && contrabandCount++)
    return contrabandCount;
}

With filter :

 function scan(searchabelItem, freightItems, contrabandCount = 0) {
        freightItems.filter((value) => value === searchabelItem && contrabandCount++)
        return contrabandCount;
    }

answered Jun 25, 2020 at 3:30

Ala Eddine Menai

2,9047 gold badges32 silver badges61 bronze badges

Collectives™ on Stack Overflow

JavaScript: forEach function is not specifying the item to count in iteration loop

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related