Avoid repetition of loop body before loop

Question

Ws you can see below, the code above and under the start of loop looks pretty much same. Is it possible to avoid this repetition?

Code:

term = ","
file_name = input("What is the file name? ")
f_extns = file_name.split(".")  #splitting file extension from file name
while term in file_name:
     print("Please type file name again with . not, ")
     file_name = input("What is the file name? ")
     f_extns = file_name.split(".")
else:
    print("The file extension is: " + repr(f_extns[-1]))

Does this answer your question? Asking the user for input until they give a valid response See the top answer under Implementing Your Own Validation Rules — wjandrea
– wjandrea, Commented Jul 5, 2020 at 20:36
Yeah, you can do it. Create a function that has the code in it, and just call it when you need. — alfadog67
– alfadog67, Commented Jul 8, 2020 at 16:43

Brian61354270 · Accepted Answer · 2020-07-05 20:39:36Z

2

You could use an infinite loop and only break when the exit condition is met.

while True:
    file_name = input("What is the file name? ")
    f_extns = file_name.split(".")

    if term not in file_name:
        break
    else:
        print("Please type file name again with . not, ")

edited Jul 5, 2020 at 20:39

answered Jul 5, 2020 at 20:37

Brian61354270

14.9k7 gold badges37 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Shrey Over a year ago

Oh this is much smarter

Red Over a year ago

The else statement isn't necessary.

Brian61354270 Over a year ago

@AnnZen Quite true, but I generally lean towards including it to make the separation of the branches clearer.

Red · Accepted Answer · 2020-07-05 20:38:07Z

0

Like this:

term = ","
while True:
    file_name = input("What is the file name? ")
    if term not in file_name: # If the user didn't input any commas
        print("The file extension is: ", file_name.rsplit('.')[0])
        break
    print("Please type file name again with . not, ")

answered Jul 5, 2020 at 20:38

Red

27.7k8 gold badges44 silver badges63 bronze badges

Comments

Shrey · Accepted Answer · 2020-07-05 20:38:35Z

0

You can simplify your code by doing this

term = ","
file_name = input("What is the file name? ")
while term in file_name:
     print("Please type file name again with . not, ")
     file_name = input("What is the file name? ")
f_extns = file_name.split(".")
print("The file extension is: " + repr(f_extns[-1]))

This takes the input and as long as there is a comma in the input it will ask the user to repeat the filename. As soon as they enter a correct file name it will exit the loop and split by period.

answered Jul 5, 2020 at 20:38

Shrey

1561 gold badge2 silver badges12 bronze badges

Collectives™ on Stack Overflow

Avoid repetition of loop body before loop

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related