c++ variable size stack array in function that get const

Question

I'm learning now C++ I'm reading the book Effective C++ (Scott Meyers). In the book, there is an item about const variables, and I try to work with them. I notice something very interesting that I what to know if it bug in C++: (I'm working with C++98 standard)

void Test(const int i)
{
    int arr[i] = {0};
    
    for (int j = 0; i > j; ++j)
    {
        arr[j] = i;
    }
}

This function will compile and work exactly as I want (create int array on the stack with the size of 'i'. When I remove the 'const' from 'i' it won't compile. I try this on gcc and clang.

Edit: link to Compiler Explorer

I don't think that's standard, it might be a GCC/CLANG extension. In C++, array sizes have to be known at compile time. — Barmar
– Barmar, Commented Aug 20, 2020 at 5:30
Some compilers support the C Variable Length Arrays in C++. It is not a good idea to use it though. It interacts badly with other C++ features like templates and object creation and destruction. — Zan Lynx
– Zan Lynx, Commented Aug 20, 2020 at 5:36
@ZanLynx But if the compiler supports VLA it should work without const as well. — Barmar
– Barmar, Commented Aug 20, 2020 at 18:40

Barmar · Accepted Answer · 2020-08-20 18:38:45Z

3

To catch this kind of mistake in the future the compiler flag you want for both g++ and clang++ is -pedantic. And always remember to specify your language standard or you don't know what you'll get.

$ g++ -std=c++98 -pedantic c++-vla.cpp -o c++-vla
c++-vla.cpp: In function ‘void f(size_t)’:
c++-vla.cpp:3:30: warning: ISO C++ forbids variable length array ‘g’ [-Wvla]
    3 | void f(const size_t x) { int g[x]; }
      |                              ^

$ clang++ -std=c++98 -pedantic c++-vla.cpp -o c++-vla
c++-vla.cpp:3:31: warning: variable length arrays are a C99 feature [-Wvla-extension]
void f(const size_t x) { int g[x]; }
                              ^
1 warning generated.

edited Aug 20, 2020 at 18:38

Barmar

789k57 gold badges555 silver badges669 bronze badges

answered Aug 20, 2020 at 5:42

Zan Lynx

54.7k11 gold badges85 silver badges135 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Waqar · Accepted Answer · 2020-08-20 05:37:03Z

1

First of all, const in your function signature is ignored by the compiler. So the following two are equivalent:

Test(const int i) {}
Test(int i) {}

Secondly, this isn't valid C++ regardless of whether it compiles or not:

int arr[i] = {0};

It isn't valid because i is not a compile time constant i.e., the value of i has to be known at the time of compilation.

Try on Compiler Explorer

edited Aug 20, 2020 at 5:37

answered Aug 20, 2020 at 5:33

Waqar

9,5496 gold badges39 silver badges47 bronze badges

6 Comments

Barmar Over a year ago

I think const in the function signature prevents assigning the variable inside the function.

Waqar Over a year ago

Yes, but to the compiler it doesn't make a difference whether it is const or not (for value types).

Barmar Over a year ago

It doesn't make a difference when deciding whether to allow it to be used as an array size, but it makes a difference for other things.

Izik Avinoam Over a year ago

I try it on compiler Compiler Explorer - link This compiled and work

Waqar Over a year ago

That's because of GCC's own extensions that make it work. Compile with -pedantic and then see what happens. Also, read this post for a bigger answer to why GCC allows this: stackoverflow.com/questions/39334435/…

|

Collectives™ on Stack Overflow

c++ variable size stack array in function that get const

2 Answers 2

Comments

6 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related