How to include file multiple times in PHP?

Question

I have a standardized sequence of code which I used to display topic information on the home page and other pages on my site. I want to throw it in an include file so that I don't have to keep fixing multiple pages. The problem is sometimes this include occurs in a while statement which means there was a previous query supplying information for sorting purposes.

When the code is raw in the while statement, it works as it should and if there are multiple ids being served to the code from the previous query, it shows multiple results. However, if this code is in an include, I will only see one result. I assume because the include file only executes once. How would I serve an include file as the equivalent as my raw code?

Include

//outside query
while($row = $stmt->fetch(PDO::FETCH_ASSOC))
{
    $topic_id=htmlspecialchars( $row['topic_id'], ENT_NOQUOTES, 'UTF-8' );
    //code to display topics
    include('display_topics.php');  
}

Raw Code

//outside query
while($row = $stmt->fetch(PDO::FETCH_ASSOC))
{
    //code to display topics
    $sql = "SELECT * FROM topic WHERE id=?";
    $stmt = $conn->prepare($sql);
    $stmt->bindValue(1,topic_id, PDO::PARAM_INT);
    $result=$stmt->execute();
}

while($row = $stmt->fetch(PDO::FETCH_ASSOC))
{
    //yada yada
    ...
}

Make it as a FUNCTION -- one of it's purposes is to implement a code snippet that can be called multiple times with (possibly) different arguments -- in other words "code reuse". — LazyOne
– LazyOne, Commented Jun 21, 2011 at 19:19
Would it be possible to restructure display_topics.php so it provides a function you call to perform its operations rather than having it just run? — qid
– qid, Commented Jun 21, 2011 at 19:20
Possible duplicate of PHP include file multiple times in one page — jww
– jww, Commented Oct 13, 2018 at 2:21

Pekka · Accepted Answer · 2011-06-21 19:17:30Z

12

Don't do it this way.

It's much better to do one include, and to declare a function in it that does what you need:

function display_topics($topic_id)
 { 
   ....
 }

Call that function inside the loop, and pass all necessary data to it.

answered Jun 21, 2011 at 19:17

Pekka

451k150 gold badges989 silver badges1.1k bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

meteorainer Over a year ago

Ya, this is the better way to go :)

cwallenpoole Over a year ago

Curses! Foiled again by a concise answer!

Scarface Over a year ago

Wow you are getting mad votes. That is the fastest I have seen +10.

Pekka Over a year ago

@Scarface yeah, and I don't entirely understand why! It's not that outstanding an answer really. Ah well. :)

Scarface Over a year ago

It's not the size, it's how you use it haha. It got the job done.

|

Peetz · Accepted Answer · 2011-06-21 19:17:38Z

1

Include the file as normal, but put the repeated code in a function. Then, where you wish to add the code simply call the function.

answered Jun 21, 2011 at 19:17

Peetz

1671 silver badge14 bronze badges

Comments

cwallenpoole · Accepted Answer · 2011-06-21 19:22:27Z

1

That word, I don't think it is for what you think it is for.

Generally, include's use should not be used that way. That's why God invented functions (or Ada Byron, if you're not theologically inclined).

Try this instead:

function execute_row($row, $conn)
{
    $topic_id=htmlspecialchars( $row['topic_id'], ENT_NOQUOTES, 'UTF-8' );
    $sql = "SELECT * FROM topic WHERE id=?";
    $stmt = $conn->prepare($sql);
    $stmt->bindValue(1,topic_id, PDO::PARAM_INT);
    return $stmt->execute();
}

Then, in your while statement:

while($row = $stmt->fetch(PDO::FETCH_ASSOC))
{
    $result = execute_row($row, $conn);
}

TADA! And the best part is, it makes your code smaller, easier to read, and faster to parse.

answered Jun 21, 2011 at 19:22

cwallenpoole

82.4k26 gold badges132 silver badges174 bronze badges

3 Comments

Scarface Over a year ago

I agree functions should be used, but within an include in this case. This function is reoccurring on about 7 different pages so the reason I even thought of include was so I did not have to go around fixing all these pages, I could just fix one.

Pekka Over a year ago

@Scarface you would keep the function in one location location. Or if they're 7 similar but different ones, the next step would be to build a function so abstract that it can serve all 7 purposes.

Scarface Over a year ago

Are you referring to OOP type techniques?

Collectives™ on Stack Overflow

How to include file multiple times in PHP?

3 Answers 3

9 Comments

Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

9 Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related