Getting individual values from an ArrayList<Integer>

Question

I'm trying to get the individual values from an ArrayList but I haven't had any luck. It appears that when I go through the loop, it's overwriting the i Integer variable being used in the for loop.

public ArrayList<Integer> getTests() 
{
    return tests;
}


// Go through all the tests downloaded from the bluetooth module
        for (Integer i :ma.mOpacityTestResult.getTests())
        {
            View row = inflater.inflate(R.layout.test_report_row, (ViewGroup) container, false);
            TextView left = (TextView) row.findViewById(R.id.rowLeft);
            TextView right = (TextView) row.findViewById(R.id.rowRight);

            // This is the checkbox we want shown but to only worth with counter
            CheckBox check = (CheckBox) row.findViewById(R.id.checkBox);
            check.setVisibility(View.VISIBLE);
            check.setChecked(true);


            String testResultString = getString(R.string.TestNumber) + String.valueOf(counter++);

        // Load getTest Results into a list
          List<Object> list = new ArrayList<>();
          list.add(i);          // Trying to seperate each value of i download from bluetooth here but failing
        }

Priyanka · Accepted Answer · 2020-12-10 07:01:47Z

1

You need to keep initialization out of the loop

This should be outside the loop

List<Object> list = new ArrayList<>();

Only addition of values to list should be in the loop

list.add(i);

answered Dec 10, 2020 at 7:01

Priyanka

1,8851 gold badge9 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sahil Bora Over a year ago

If I want to get the first element of the list by using list.get(0), it's still returning the last item of the i variable even though I've specifically selected the 0 index.

D George · Accepted Answer · 2020-12-10 04:11:21Z

1

Your code is creating a new list on every iteration and adding the value. So at the end of final iteration, only the list created in the last iteration will be left, which gives a feeling that the value in the list is being overwritten. To fix this, the list initialization (List list = new ArrayList<>();) has to be done outside the for loop.

answered Dec 10, 2020 at 4:11

D George

1881 silver badge11 bronze badges

3 Comments

Sahil Bora Over a year ago

I added the List initialization outside the for loop the i variable is still getting overwritten

D George Over a year ago

Can you please paste the updated code? It should ideally work.

Sahil Bora Over a year ago

It turns out that by using a switch statement, I wasn't somehow getting the correct values from the list but when I was using if.. statements it was working.

Collectives™ on Stack Overflow

Getting individual values from an ArrayList<Integer>

2 Answers 2

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related