JavaScript get common element in two arrays

Question

I have this array which is eewootags:

and I have another array evProductTag which is below:

I am trying to get the id which is common to both.

This is what I tried:

var tagdataexist = [];
for (var i = 0; i < evProductTag.length; i++) {
  for (var j = 0; j < eewootags.length; j++) {
    if (eewootags[j].name == evProductTag[i].name){
      tagdataexist.push(eewootags[i].id);
    }
  }
}
console.log(tagdataexist);

But this gives be 193 instead of 187.
Tag2 is the common element by name.

Please help!

Please show all data as text, not as pictures of text. Note that getting data from JavaScript is often easier using console.log(JSON.stringify(obj, null, 2)) to get a string value you can then copy and paste. Please try to limit the amount of data to only enough to demonstrate the problem. — Heretic Monkey
– Heretic Monkey, Commented Feb 4, 2021 at 21:58

Alessio Cantarella · Accepted Answer · 2021-02-04 22:10:40Z

1

Your problem is with the indexes of your array: you access eewootags with both i and j. You need to use always the same index!

let eewootags = [
  {id: 193, name: 'Tag 8'},
  {id: 186, name: 'Tag1'},
  {id: 187, name: 'Tag2'},
  {id: 188, name: 'Tag3'},
  {id: 189, name: 'Tag4'},
  {id: 190, name: 'Tag5'},
  {id: 191, name: 'Tag6'},
  {id: 192, name: 'Tag7'},
  {id: 194, name: 'Tag9'}
];
let evProductTag = [
  {name: 'Tag2'},
  {name: 'Tag 3'},
  {name: 'Tag 69'}
];
let tagdataexist = [];
for (let i = 0; i < eewootags.length; i++) {
  for (let j = 0; j < evProductTag.length; j++) {
    if (eewootags[i].name == evProductTag[j].name) {
      tagdataexist.push(eewootags[i].id);
    }
  }
}
console.log(tagdataexist);

edited Feb 4, 2021 at 22:10

answered Feb 4, 2021 at 22:04

Alessio Cantarella

5,2413 gold badges31 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Frenchy · Accepted Answer · 2021-02-04 22:08:59Z

1

your error is just on index!

tagdataexist.push(eewootags[j].id);// j and not i

answered Feb 4, 2021 at 22:08

Frenchy

17.1k3 gold badges21 silver badges42 bronze badges

Collectives™ on Stack Overflow

JavaScript get common element in two arrays

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related