java.lang.UnsupportedOperationException with ArrayList()

Question

I have a class like this

@Getter
public class MyClass  {

    private Collection<String> headers;

    public myConfig(DownloadRequest downloadRequest) {

        this.headers = downloadRequest.getHeaders() == null ? new ArrayList() : downloadRequest.getHeaders();
    }
 }

When I run this it gives me java.lang.UnsupportedOperationException.

As I use headers in another function and do getHeaders().clear(), I get this error.

Return type of downloadRequest.getHeaders() is Collection<String>

I am unable to figure out what I can cast the headers to.

I keep getting different Exceptions as I change my code, like UnsupportedOperationException and java.lang.ClassCastException: java.util.Arrays$ArrayList incompatible with java.util.ArrayList, when I change the code to something else, trying out other StackOverflow solutions like this - Why do I get an UnsupportedOperationException when trying to remove an element from a List?.

I have just started working on Java and have been working more on python and nodejs in the past.

Any help is appreciated.

Try new ArrayList<String>(downloadRequest.getHeaders()) to convert it — azro
– azro, Commented Mar 4, 2021 at 16:45
@azro Yes that works, not getting an error with it, can accept it in some time — Akshay Hazari
– Akshay Hazari, Commented Mar 4, 2021 at 16:48
It's bad coding style to use a getter to update another object's collection field. You should create a clearHeaders() method instead. — k314159
– k314159, Commented Mar 4, 2021 at 16:52

Petr Janeček · Accepted Answer · 2021-03-04 16:52:37Z

4

The problem is that Collection#clear(), as mentioned in the docs is an optional operation and not all implementations need to support it. If they do not, they can throw UnsupportedOperationException. In your case, the list returned from downloadRequest.getHeaders() is apparently an unmodifiable collection which does not support this operation.

If it did, calling clear() on it would remove all headers from the downloadRequest. Is that what you're trying to achieve? Probably not. If yes, instead there should be a method like downloadRequest.clearHeaders().

To work around this problem, you can copy the elements out of an unmodifiable collection into e.g. an ArrayList:

new ArrayList<>(downloadRequest.getHeaders())

This copies the elements out of the original container into a new modifiable ArrayList that you can then modify however you like.

Also note you're mentioning java.util.Arrays$ArrayList which is named ArrayList, but it is not java.util.ArrayList. This is an unresizable collection returned from Arrays.asList(...) and it does not support clear() either.

answered Mar 4, 2021 at 16:52

Petr Janeček

38.5k13 gold badges128 silver badges149 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Petr Janeček Over a year ago

One last remark is that downloadRequest.getHeaders() should never return null in a good design. Methods returning null instead of an empty collection are a code smell and should only be used when null is different from an empty collection. (Actually in that case you're better of with some kind of a specialized class, but that's a different discussion.)

azro · Accepted Answer · 2021-03-04 16:47:44Z

2

The downloadRequest.getHeaders() method may return a Collection that is read-only and so doesn't support .clear()

You may use an ArrayList to wrap it and get a write-accessible structure

// private list<String> headers;


Collection<String> headers = downloadRequest.getHeaders();
this.headers = headers  == null ? new ArrayList<>() : new ArrayList<>(headers) ;

answered Mar 4, 2021 at 16:47

azro

54.2k9 gold badges39 silver badges75 bronze badges

Comments

jmaniquet · Accepted Answer · 2021-03-04 16:49:38Z

0

I think you may be using the wrong ArrayList class when doing new ArrayList()

From your ClassCastException you are using : java.util.Arrays$ArrayList, which is a nested class of the Arrays class and is immutable.

Check your import : you should be using java.util.ArrayList.

Edit : never mind this nested class is private; previous answer is probably right, the collection returned must be immutable.

answered Mar 4, 2021 at 16:49

jmaniquet

1036 bronze badges

Collectives™ on Stack Overflow

java.lang.UnsupportedOperationException with ArrayList()

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related