CakePHP - Validation rule has syntax error I can't see

Question

I'm getting Parse error: syntax error, unexpected T_VARIABLE, expecting ')' on the line commented below. Can't for the life of me figure out why it's throwing this error.

public $validate = array(
    'password1' => array(
        'rule1' => array('rule' => 'alphaNumeric', 'message' => 'Your password should only contain alphanumeric characters.'),
        'rule2' => array('rule' => '/\d/', 'message' => 'Your password must contain at least one numeric character.'),
        'rule3' => array('rule' => '/^(?=.*?[A-Z])(?=.*?[a-z])/', 'message' => 'Your password must contain at least one uppercase and one lowercase letter.'),
        'rule4' => array('rule' => array('minLength', 8), 'message' => 'Your password must be at least 8 characters long.'),
    ),
    'password2' => array(
        // ERROR ON LINE BELOW
        'rule' => array('_passwordsMatch', $this->data['PasswordReset']['password2']),
        'message' => 'The passwords you entered do not match.'
    )
);

/**
 * Custom validation method to check that the entered passwords match
 *
 * @param  string $password1
 * @param  string $password2
 * @return bool
 */
protected function _passwordsMatch($password1, $password2) {
    return ($password1 === $password2);
}

As you can see I'm trying to make a custom validation rule to check the two passwords coming from the user's submitted form. Related question would be is this the wrong way to be trying to pass the other field value to the custom rule?

Ferdinand Beyer · Accepted Answer · 2011-07-22 15:52:01Z

1

You are not allowed to reference $this during the initialization syntax of a class property. If you really need that, you must move the array definition to the class constructor.

Quoting the Documentation:

[Properties] are defined by using one of the keywords public, protected, or private, followed by a normal variable declaration. This declaration may include an initialization, but this initialization must be a constant value--that is, it must be able to be evaluated at compile time and must not depend on run-time information in order to be evaluated.

This rule is enforced at compile time, so there are grammar rules for static array() syntax that do not allow arbitrary expressions. This is why you get a syntax error: Instead of $this, the parser expects a ) that closes array(.

edited Jul 22, 2011 at 15:52

answered Jul 22, 2011 at 15:39

Ferdinand Beyer

67.6k18 gold badges160 silver badges147 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

BadHorsie Over a year ago

Of course, thanks. I was so caught up in the size of the array that I forgot it's still just defining a class property. Thank you. So how would you suggest I compare the two passwords using the validate array?

Ferdinand Beyer Over a year ago

Actually, I don't know CakePHP, so I'm afraid I cannot be of great help with your validator code. Maybe there is some pre-defined special validator for this task or you can somehow register a callback function for the validation...

Ferdinand Beyer Over a year ago

A very short google search leads to this: littlehart.net/atthekeyboard/2008/01/22/… -- There is an example of how to do the password confirmation.

Community · Accepted Answer · 2017-05-23 12:04:17Z

0

funny how this comes up this often right now check out CakePHP validation rule to match field1 and field2 for a clean behavior approach on this subject (see my answer)

also note: your alphanumeric rule is out of line in my opinion. you should never force a user to use less chars then he wants in a password field. many users use at least some special char and DONT use your upper or lower case style. i think you are restricting the user more than needed.

edited May 23, 2017 at 12:04

CommunityBot

11 silver badge

answered Jul 23, 2011 at 10:11

mark

21.8k3 gold badges54 silver badges75 bronze badges

Collectives™ on Stack Overflow

CakePHP - Validation rule has syntax error I can't see

2 Answers 2

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related