Js FOR loop returning 'undefined'

Question

Im trying to add asterisks at the beginning and end of each word but I keep getting undefined at the end of my new string. Thanks for the help in advance.

function solution(s) {
var asterisks = "*"
var newString = ""
for(let i = 0; i <= s.length; i++){
    if(s === ""){
        return "*";
    }else{
    newString += asterisks + s[i];} 
}
return newString;
}

for example if were to log solution("star"), I would get "starundefined" But what I want is "*star*" — bmoreaaron
– bmoreaaron, Commented Nov 16, 2022 at 3:31

Jiangqi Zhu · Accepted Answer · 2022-11-16 03:11:25Z

2

I think your for loop should be

for(let i = 0; i < s.length; i++)

Cause in the last time of your for loop, i = s.length.

And s[s.length] = undefined

answered Nov 16, 2022 at 3:11

Jiangqi Zhu

515 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

John · Accepted Answer · 2022-11-16 03:16:03Z

0

Your issue is for(let i = 0; i <= s.length; i++) the <= should just be < the undefined is coming from the last "length" character not existing.

You can get around adding the final * and the end of the last letter by add this code to the for loop:

if (i == (s.length -1)){
    return newString += asterisks;
    }

Working example:

function solution(s) {
var asterisks = "*"
var newString = ""
for(let i = 0; i < s.length; i++){
    if(s === ""){
        return "*";
    }else{
    newString += asterisks + s[i];} 
    
    if (i == (s.length -1)){
    return newString += asterisks;
    }
}
return newString;
}

document.getElementById("test").innerHTML = solution('hello');

<div id="test"></div>

answered Nov 16, 2022 at 3:16

John

5,3621 gold badge8 silver badges18 bronze badges

Collectives™ on Stack Overflow

Js FOR loop returning 'undefined'

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related