Overlapping accesses to frame

Question

I put two functions in the code but it gives me this error:

Overlapping accesses to 'frame', but modification requires exclusive access; consider copying to a local variable

how can i solve?

import UIKit

extension UITabBarController {
    
    func hideTabBar() {
        var frame = self.tabBarController?.tabBar.frame
        frame?.origin.y = self.view.frame.size.height + (frame?.size.height)!
        UIView.animate(withDuration: 0.5, animations: {
            self.tabBarController?.tabBar.frame = frame!
        })
    }

    func showTabBar() {
        var frame = self.tabBarController?.tabBar.frame
        frame?.origin.y = self.view.frame.size.height - (frame?.size.height)!
        UIView.animate(withDuration: 0.5, animations: {
            self.tabBarController?.tabBar.frame = frame!
        })
    }
    
}

@OneCommentMan added, but now it gives me this error: Extensions must not contain stored properties — iosSwift
– iosSwift, Commented Apr 18, 2023 at 7:41
So the issue of your function is you accessing frame while you're trying to modify it. You can update your function to something like this. func hideTabBar() { guard var frame = self.tabBarController?.tabBar.frame else { return } let originY = self.view.frame.size.height + t.size.height frame.origin.y = originY UIView.animate(withDuration: 0.5) { self.tabBarController?.tabBar.frame = frame } } — OneCommentMan
– OneCommentMan, Commented Apr 18, 2023 at 7:44
@OneCommentMan if i put it inside the extension of UITabBarController it doesn't work — iosSwift
– iosSwift, Commented Apr 18, 2023 at 8:21

Geoff Hackworth · Accepted Answer · 2023-04-18 09:08:59Z

0

The code seems to be violating Swift’s exclusive access rules but I’m not smart enough to know why! But rewriting the methods to avoid all the optionals fixes the compiler errors:

extension UITabBarController {
    func hideTabBar() {
        var frame = tabBar.frame
        frame.origin.y = view.frame.size.height + frame.size.height
        UIView.animate(withDuration: 0.5, animations: {
            self.tabBar.frame = frame
        })
    }

    func showTabBar() {
        var frame = tabBar.frame
        frame.origin.y = view.frame.size.height - frame.size.height
        UIView.animate(withDuration: 0.5, animations: {
            self.tabBar.frame = frame
        })
    }
}

I don’t think adjusting the tab bar’s frame is very safe and you might have problems (anything that triggers a relayout of the tab bar controller could make the tab bar appear again). If you are hiding the tab bar when pushing a view controller on a navigation stack then this might be better: https://developer.apple.com/documentation/uikit/uiviewcontroller/1621863-hidesbottombarwhenpushed

edited Apr 18, 2023 at 9:08

answered Apr 18, 2023 at 7:45

Geoff Hackworth

3,1741 gold badge20 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

iosSwift Over a year ago

if i put it inside the extension of UITabBarController it doesn't work

iosSwift Over a year ago

maybe I have to remove self?

Geoff Hackworth Over a year ago

Your original question didn’t say the code was in an extension of UITabBarController. I have updated my answer but am using a Playground on iPad so only compiled the code. I have not run it to test.

Collectives™ on Stack Overflow

Overlapping accesses to frame

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related