Using jquery to calculate some form fields

Question

I am quite new to jquery and am gradually working through my book! I have generated this simple calculator for some form field values. Basically if the user select percentage a pecentage calculation occurs and the results are put into another form field. If the user selects mvalue the script just places that value into the form field instead. The percentage calculator works perfectly, the problem is with the second part of the script, the error message in firefox is calcVal.toFixed is not a function. My apologies if this code is overkill or chunky, but as i say i am still learning.

<script type="text/javascript">
         function myCalc() {
        var selectVal = $('##txt_passoc_type#currentrow# :selected').val();
        var valBox = $('##mon_value#currentrow#').val();
        var currentPrice = $('##currentPrice#currentrow#').val();
        if (selectVal == "Percentage"){
        var calcVal = ((currentPrice * valBox)/100);
        var myTotal = currentPrice - calcVal;
        var myCleanTotal = myTotal.toFixed(2);
         $('##mon_paasoc_dprice#currentrow#').val(myCleanTotal);
         $('##screenPrice#currentrow#').val(myCleanTotal);
     }
    else if (selectVal == "MValue"){
        var myVal = $('##mon_value#currentrow#').val();
        var calcVal = myVal
        var myTot = calcVal.toFixed(2);
        $('##mon_paasoc_dprice#currentrow#').val(myVal);
         $('##screenPrice#currentrow#').val(myVal);


    }

         }

    </script>

Any help is appreciated.

Jason

Nicola Peluchetti · Accepted Answer · 2011-11-30 13:03:40Z

2

the problem is that you are calling toFixed() on a String and it can obnly be called on a number

For example this gives an error

var calcVal = "3";
var myTot = calcVal.toFixed(2);

And this doesn't

var calcVal = "3";
calcVal = parseInt(calcVal , 10);
 var myTot = calcVal.toFixed(2);

So in your example you should do:

else if (selectVal == "MValue"){
    var myVal = $('##mon_value#currentrow#').val();
    var calcVal = parseInt(myVal, 10);//convert to a Number!
    var myTot = calcVal.toFixed(2);
    $('##mon_paasoc_dprice#currentrow#').val(myVal);
     $('##screenPrice#currentrow#').val(myVal);
}

You don't need to do anything in the if part because calcVal is a number

 var calcVal = ((currentPrice * valBox)/100);//Here calcVal is a number already
 var myTotal = currentPrice - calcVal;

answered Nov 30, 2011 at 13:03

Nicola Peluchetti

77k32 gold badges150 silver badges197 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jason Congerton Over a year ago

awesome, thank you! been pulling my hair out! apart from that is the rest of code looking ok i.e not to heavy etc.

chawkinsuf · Accepted Answer · 2011-11-30 13:04:43Z

2

It might be helpful if you posted your html along with the javascript, however I suspect you are calling toFixed on a string. You should try this instead:

parseFloat(calcVal).toFixed(2)

answered Nov 30, 2011 at 13:04

chawkinsuf

1,4011 gold badge14 silver badges14 bronze badges

Collectives™ on Stack Overflow

Using jquery to calculate some form fields

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related